Overview
Request 1007740 accepted
- Update to kernel headers 6.0 (forwarded request 1007739 from Andreas_Schwab)
- Created by Andreas_Schwab
- In state accepted
- Supersedes 992204
Candidate to break linux-atm:
[ 37s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/linux-atm-2.5.2/src/maint' [ 37s] gcc -DHAVE_CONFIG_H -I. -I../.. -I./../q2931 -I./../saal -I. -I../../src/include -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -Wall -Wshadow -Wpointer-arith -Wwrite-strings -Wstrict-prototypes -c -o atmaddr.o atmaddr.c [ 37s] atmaddr.c: In function 'main': [ 37s] atmaddr.c:100:52: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=] [ 37s] 100 | fprintf(stderr,"internal error: len %d %% %d\n",req.length, [ 37s] | ~^ [ 37s] | | [ 37s] | int [ 37s] | %ld [ 37s] 101 | sizeof(*addr)); [ 37s] | ~~~~~~~~~~~~~ [ 37s] | | [ 37s] | long unsigned int [ 37s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/linux-atm-2.5.2/src/maint' [ 37s] make[3]: Entering directory '/home/abuild/rpmbuild/BUILD/linux-atm-2.5.2/src/maint'
This must be broken regardless linux-glibc-devel. sizeof() and %d will never work together on 64bit. That should be %zu.
Seems to break linux-atm
This makes more sense:
zntune.c:18:10: fatal error: linux/atm_zatm.h: No such file or directory
The related commit:
commit 052e1f01bfae8be6f31b61ed3a2356edfca855dc
Author: Jakub Kicinski <kuba@kernel.org>
Date: Tue Apr 26 10:54:33 2022 -0700
net: atm: remove support for ZeitNet ZN122x ATM devices
It should not remove an uapi header...
Ups, indeed. sorry, I picked the wrong stuff from the log (which was in fact only a warning)
Reported:
https://lore.kernel.org/all/8576aef3-37e4-8bae-bab5-08f82a78efd3@kernel.org/
Fix at:
https://lore.kernel.org/all/20220810164547.484378-1-kuba@kernel.org/
Will be in kernel 6.0. I suppose @Andreas_Schwab, you'll wait for 6.0 headers (unless they break something again)?
Unignored: returned to active backlog.
Request History
Andreas_Schwab created request
- Update to kernel headers 6.0 (forwarded request 1007739 from Andreas_Schwab)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
favogt_factory set openSUSE:Factory:Staging:B as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:B"
favogt_factory accepted review
Picked "openSUSE:Factory:Staging:B"
dimstar accepted review
favogt_factory accepted review
Staging Project openSUSE:Factory:Staging:B got accepted.
favogt_factory approved review
Staging Project openSUSE:Factory:Staging:B got accepted.
favogt_factory accepted request
Staging Project openSUSE:Factory:Staging:B got accepted.
Breaks VirtualBox:
CC @lwfinger @larryr
Unless there is some kind of funky, undocumented union at play here, I am surprised that this ever worked.
I reworked our definition of 'struct USBPROXYURBLNX' to move the offending entry to the end of the struct.