Overview

Request 1062215 accepted

See superseded desc

Loading...

Matej Cepl's avatar

Two points, one is just a cosmetic, other not so:

  • The nitpick is %{python_sitelib}/cloup-*.egg-info. We prefer %{python_sitelib}/cloup-%{version}*-info. First, when there is a problem with generated metadata, they often end up with directory %{python_sitelib}/cloup-0.0.0*-info, so checking the version is a good Canary in a Coal Mine for that. Second, packages with %pyproject_wheel (which is now preferred way of building packages) have the directory ending with .dist-info, so I usually put that difference into asterisk.

  • More important question is whether this package doesn’t belong more to devel:languages:python:numeric which is the home of our scientific/numerical packages. Do you expect any package outside of that project will ever use this one?


Markéta Machová's avatar

another one: you have twice BuildRequires: %{python_module pytest}


Eyad Issa's avatar
author target maintainer

Thank you for you time.

Request History
Eyad Issa's avatar

VaiTon created request

See superseded desc


Matej Cepl's avatar

mcepl accepted request

Thank you!

openSUSE Build Service is sponsored by