Overview
Request 1097823 accepted
go (forwarded request 1097822 from bnavigator)
- Created by bnavigator
- In state accepted
Request History
bnavigator created request
go (forwarded request 1097822 from bnavigator)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot added openSUSE:Factory:Staging:adi:2 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:2"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:adi:2"
darix declined request
mrueckert wrote (1097823),looks like a typo in,,```,+BuildRequires: %{python_module jsonschema > 2.6 with %python-jsonschema < 4.18},```
anag+factory reopened request
Reopened via staging workflow.
anag+factory added factory-staging as a reviewer
Being evaluated by group "factory-staging"
anag+factory accepted review
Unstaged from project "openSUSE:Factory:Staging:adi:2"
anag+factory declined request
Declined via staging workflow.
bnavigator reopened request
@darix: no it is not a typo. This is how it works:
https://github.com/openSUSE/python-rpm-macros#macros
> %{python_module modname args} expands to (-modname args) for every flavor. Intended as: BuildRequires: %{python_module foo >= version}. Supports rpm boolean dependencies. If the package needs a module only for a specific Python version, you can use the special pseudo-macro %python for expansion of the python-flavor within the requirement, e.g. BuildRequires: %{python_module python-aiocontextvars >= 0.2.2 if %python-base < 3.7}. (Don't define %python anywhere else.)
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:35"
staging-bot accepted review
Picked "openSUSE:Factory:Staging:adi:35"
darix accepted review
Accepted review for by_group opensuse-review-team request 1097823 from user staging-bot
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:35 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:35 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:35 got accepted.
Requires either a new python-jsonschema417 package https://build.opensuse.org/request/show/1097824 or that python-jsonschema be reverted to <4.18
@darix
BuildRequires: %{python_module jsonschema > 2.6 with %python-jsonschema < 4.18}Is not a typo, it is a correct statement with the way %python_module is defined in the prjconf. It expands to
BuildRequires: (python39-jsonschema > 2.6 with python39-jsonschema < 4.18) (python310-jsonschema > 2.6 with python310-jsonschema < 4.18) (python311-jsonschema > 2.6 with python311-jsonschema < 4.18)for both:
%python_module_iter()%python_module_lua()