Thanks for the submission erefd. Accepting and will make some follow-up changes:

• BuildRequires: golang(API) > 1.18 while returning the correct results is better expressed as BuildRequires: golang(API) >= 1.19.

The application go.mod specifies go1.19, so using that value in the expression make it clearer that the packaging and go.mod have been looked at recently and match. It also helps with grep searches to use the same convention.

• Re-adding ldflags version info back since --version option always print (devel) -ldflags "-X main.version=%{version}"

I would normally decline this as obsolete for packaging since go1.18+ embed equivalent metadata in runtime/debug.ReadBuildInfo. However this upstream package is doing something unexpected in:

https://github.com/mvdan/sh/blob/master/cmd/shfmt/main.go#L73 and https://github.com/mvdan/sh/blob/master/cmd/shfmt/main.go#L168-L176

Accepting the ldflags addtion for now on that basis. Once I understand the upstream rationale and make a PR, will add a comment in our packaging to explain and possibly carry a small patch until the PR lands.

The RPM package version is also a source of this information.

@erefd one additional comment: please consider adding a name or handle also used on other sites to your OBS profile. It is easier to accept submissions that will be forwarded to Factory when there is a point of contact for follow-up questions and the quality of the changelog.

Jeff Kowalczyk (jfkw) - 11 months ago

reviewer target maintainer

@erefd: My mistake, looking farther back in the changelog you do have a handle "Erefd X" configured, comment retracted.