Please review sources

Check script succeeded

ok

Being evaluated by staging project "openSUSE:Factory:Staging:adi:9"

Picked "openSUSE:Factory:Staging:adi:9"

mrueckert wrote (1146980) (https://build.opensuse.org/request/show/1146980),1. This is definitely wrong,,```,# The post modprobe is helpful for the user, but not really necessary, don't error if it fails,%post,%{_prefix}/sbin/modprobe i2c-dev ||:,```,,This will only last until the next reboot. so if it is recommended that this package is loaded then there should be a config file that ensures loading.,but this should probably be done in a subpackage.,,there is a sample file in https://github.com/digitaltrails/ddcutil-service/blob/master/i2c-dev/ddcutil-service.conf,,2. This might need an audit from the security team for a new system wide dbus service

Thanks for looking into this request. I think perhaps you overlooked the spec's existing attempt to address you concerns:

darix: "there should be a config file that ensures loading"

The spec does already contain a config file that ensures this request, the spec contains the line:

install -m 0644 -D -t %{buildroot}%{_prefix}/lib/modules-load.d/ i2c-dev/%{name}.conf

Michal Suchanek (OpenSUSE) suggested up with the module install step. I consulted with Michal and Sanford Rockowitz (author of ddcutils and libddcutil) in coming up with this line in the spec.

I added the modprobe so the user would not have to reboot to start using the package. Strictly speaking it's unnecessary, after the config file is in place a reboot should cover it. The main reason I don't insist on the modprobe succeeding is that it causes issues for the web OBS builds.

In respect to the security issue, if I did remove the module .conf file and i2c-dev, then the security situation would be the same as ddcutil.

Also in respect to security, the spec does have a "Recommends:" for the existing package ddcutil-i2c-udev-rules. The existing package adds a udev-rule with TAG+="uaccess" to make the i2c-dev devices available to the current desktop user.

I would be happy to remove the conf and/or the modprobe and leave it up to the user to do this manually (the C code already errors appropriately if i2c-dev isn't available). That would bring this package inline with ddcutil which also requires i2c-dev, but leaves it's up to the user to manually do so. I do think Michal is correct in suggesting it be done automatically, this kind of admin often intimidates non-technical users, ultimately I'm pursuing all this to give uses of my vdu_controls desktop tray application a better experience.

Let me know what would be acceptable and I'll amend the package accordingly.

Accepted review for by_group opensuse-review-team request 1146980 from user mchnz

Staging Project openSUSE:Factory:Staging:adi:9 got accepted.

Staging Project openSUSE:Factory:Staging:adi:9 got accepted.

Staging Project openSUSE:Factory:Staging:adi:9 got accepted.