Overview

Request 1153049 accepted

- As far as it is known the kernel has a working recvmmsg
pass --enable-recvmmsg to configure.
- Don't --enable-mmap. Replacing malloc may sound attractive but
all safety checks to prevent corruption included in libc are lost.

Loading...

Adam Majer's avatar

So, regarding the mmap, it's only used in one instance in namedb_open() and in this case NSD is using its own allocator anyway -- see region-allocator.c . IMHO, there are no advantages of using xalloc() here vs. mmap(), or actually the other way around.

But I do agree that --enable-recvmmsg should be enabled. It's actually a little surprising that they write their own implementation when this is not enabled. The setting is not enabled by enabled by default.

Request History
Cristian Rodríguez's avatar

elvigia created request

- As far as it is known the kernel has a working recvmmsg
pass --enable-recvmmsg to configure.
- Don't --enable-mmap. Replacing malloc may sound attractive but
all safety checks to prevent corruption included in libc are lost.


Adam Majer's avatar

adamm accepted request

Thanks!

openSUSE Build Service is sponsored by