Overview
Request 1157064 accepted
- Add get_llvm_tool_names-llvm18.patch to accept LLVM 18.1.
- Created by aaronpuchert
- In state accepted
-
Package maintainers:
XRevan86 and
dimstar
Loading...
Request History
aaronpuchert created request
- Add get_llvm_tool_names-llvm18.patch to accept LLVM 18.1.
gnome-review-bot accepted review
Check script succeeded
gnome-review-bot approved review
Check script succeeded
dimstar accepted request
Not sure if this is the right thing to do, but it fixes the tests. Upstream has decided to use minor version 1 for stable releases, and apparently we need that.
does that mean with 18.2 it will be renamed again? So now we need to chase minor versions not only majors?
There should be no 18.2, the only minor versions are supposed to be 0 (on the development branch) and 1 (on release branches). See https://discourse.llvm.org/t/rfc-name-the-first-release-from-a-branch-n-1-0-instead-of-n-0-0/75384.
Upstream Meson will probably have to track both if they allow building against development builds of LLVM, but for us only the release version should be interesting.
To be fair, I also don't completely understand what the test does. Meson seems to invoke CMake for the test, but it doesn't use the CMake mechanism to find LLVM apparently. (Which would be
find_package(LLVM), which doesn't need a version suffix.)