You're not reviewing the full diff of
request 1167674
, but the diff to the superseded
request 1164240
(Show full diff)
Overview
Loading...
target maintainer
Why do we need to move back to 8 instead of using GCC 9? Also, %suse_version < 1500 is better to be used there than %sle_version, since %sle_version is to differentiate between service packs, not major codestreams.
author
1) There's no need to go back to gcc-8. In fact it could be raised to anything that's supported by SLE_15_SP2, but it's hard to find, because search at https://software.opensuse.org/ is broken.
2) From https://en.opensuse.org/openSUSE:Build_Service_cross_distribution_howto#Detect_a_distribution_flavor_for_special_code it wasn't clear that all openSUSE Leap 15.* have %suse_version defined. Also, that wouldn't work for SLE_15_SP*?
Login required, please
login
in order to comment
@adamm: review reminder