Overview

Request 184023 accepted

- Drop fdupes usage, this breaks build of packages depending on only QtGlib
- Adjust cmake flags for latest release
- Remove boost-devel Requires from gstreamer-0_10-plugins-qt-devel, it is pulled by libQtGlib-devel package

Request History
Hrvoje Senjan's avatar

sumski created request

- Drop fdupes usage, this breaks build of packages depending on only QtGlib
- Adjust cmake flags for latest release
- Remove boost-devel Requires from gstreamer-0_10-plugins-qt-devel, it is pulled by libQtGlib-devel package


Tomáš Chvátal's avatar

scarabeus_iv declined request

Thanks for the patch, but the BUILD_TYPE release is bad idea, keep there the RelWithDebInfo as otherwise the -debug packages are virtually useless.

I have to decline this because this tool does not allow me to just put comment in here so far so just resubmit with that line back to RelWithDebInfo or drop me mail why you think I am wrong (i might be ;-)).


Hrvoje Senjan's avatar

sumski approved review

Wrt. BUILD_TYPE, RelWithDebInfo has aditional -g flag opposed to Release, but we have that flag in %{optflags}, and they are exported few lines above, so at the end, same flags are used. Additionally, generated cmake targets are now for release (which is in turn consistent with depending KDE packages, though not necesarry).


Tomáš Chvátal's avatar

scarabeus_iv accepted request

Ok in that case its fine. Thanks for explaining. I know it also provides some -DDEBUG on some builds so wanted to be sure this is just cflags altering.

openSUSE Build Service is sponsored by