Thanks for updating nextcloud to 12.0! I noticed you added:

git files should not be removed, otherwise nextcloud rise up ntegrity check failure.
rm find . -name ".gitignore" -or -name ".gitkeep"

Is this absolutely needed? Maybe the integrity check failures can be fixed by also removing lines containing .gitignore and .gitkeep from signature.json files? Have you tried adding code similar to the next lines after removing such files?

find . -iname signature.json \
    -exec sed -i "/\/.gitignore\": ./d" "{}" \;  \
    -exec sed -i "/\/.gitkeep\": ./d" "{}" \;

Btw, it would also be nice to fix the typos in the changes and spec files (upstram -> upstream and ntegrity -> integrity)

Eric Schirra (ecsos) - almost 7 years ago

author source maintainer

1) git-things I have think about that, but upstream recommend not to do this. So i am not sure what i should do.....

2) typos Can i do. It is only a "Rechtschreibfehler". :-)

---

Antonio Larrosa (alarrosa) - almost 7 years ago

reviewer

1) Hmm, I checked and there's a gitignore.js file, so maybe they're used somewhere by nextcloud. Do you know if that's the case? did upstream mention any reason to recommend not to remove those git files?

2) Perfect. Also, please remove the #%%patch0 -p0 line, which seems to be useless since there's not even an associated commented #Patch0 line. I'll approve the request as soon as these typos are fixed.

---

Eric Schirra (ecsos) - almost 7 years ago

author source maintainer

Now i have made fix all your comments, include remove gitfiles and made a new request. Hope it is now okay.