Overview
Loading...
Request History
matejcik created request
- versioned requires on python-monkeysign
gnome-review-bot accepted review
Check script succeeded
Zaitor accepted review
ok, fair enough
Zaitor approved review
ok, fair enough
Zaitor accepted request
xin- I'll tweak .changes a bit before fwd to TW.
Can we assume that this will be true for ever? - aka will python-monkeysign and gnome-keysign version to be in sync,
Also: -pushd monkeysign -popd
Why this change, and is it needed / why is it better than what we currently have? (Should be noted in .changes).
If this stops being true, we can change the requirement.
Also i'm told with the improvements to python gpg bindings this requirement will be dropped anyway.
"pushd monkeysign;popd" is a no-op. It doesn't do anything. I don't know why it was there in the first place, probably a remnat of some older version of the spec, but it definitely should not be there.
as long as we build python-keysign as part of gnome-keysign, the dep is probably going to be true and we can cope with it.
OTOH: those two are built together in one repo anyway - so I'm a bit wondering what extreme corner case we're trying to fix here (python-keysign is also not extremely a moving target, so the code changes are close to none)
the problem was that gnome-keysign was first installed from the leap 42 repository and then updated from the tumbleweed repository. The update did not pull the newer monkeysign version.
The next gonme-keysign version makes monkeysign optional (in fact, 0.9 can already deal without monkeysign but needs an environment variable to be set).
so - in fact it is a user messing up his machine with incompatible repos and hoping for luck. Well, sure, we can add this kind of fixed version dep (which is not wrong) - but unless glib/gtk finally start to properly version their symbols, I can guarantee you a lot more such issues, which will not be addressed with setting requires like that.
matejcik will be able to say whether he was messing with his machine. I think he visited software.o.o and click "1-click install". For some reason, it gave him the old 0.6 version. Then he clicked "1-click install" for the 0.9 version. But again, matejcik can probably tell better what happened. When it installed the gnome-keysign as of 0.9, it did not, however, update the dependencies. Probably because there is no constraint in the spec file. Anyway, that version of gnome-keysign, i.e. 0.9, is incompatible with the monkeysign version that is packaged as 0.6.
I don't understand anything about versioning symbols. I have the feeling it's not relevant for this particular incompatibility of the monkeysign library. If it is indeed relevant and I can do something to help packaging the app, I will gladly do it.
i expect GNOME:Apps' openSUSE_Leap_42.2 repo to be compatible with openSUSE Leap 42.2 ;)
gnome-keysign and python-monkeysign are present in Leap 42.2, both in version 0.6. When you add GNOME:Apps repo and request an update, you get gnome-keysign 0.9, but without this SR, you don't get updated python-monkeysign which you in fact need.
(And which is available from the same repo and is just sitting there and will sit there happily until the end of days, because I didn't manually request a provider change for it. I was under the impression that this is how we set things up by design, and a blind "zypper-dup-me-a-full-new-repo" is what actually messes up machines ;) )
This, to me, seems to be a clear-cut packaging bug that should be fixed.
@Zaitor, @dimstar: review reminder