Well, it supports both (and prefers cdrskin if installed I think).
So I'm not sure if a Requires is really necessary here...
Though I'm not strictly against it either.
Unrelated to that, have you checked whether the other cdrecord/cdrkit tools (mkisofs, dvd+rw-tools, readcd) are still required/used with cdrskin? Or could they be removed too if we require cdrskin?
When you start k3b without cdrskin, a message pops up that states "K3b uses cdrskin in place of cdrecord.", so I believe cdrskin should be required and cdrecord could be suggested or removed all together.
As for whether or not cdrskin uses those tools, I'm not sure. From looking at the home page, it does seem to use mkisofs. Cdrskin seems to use libburn as a backend, so that would be a good place to look. I'll look into it further.
When you start k3b without cdrskin, a message pops up that states "K3b uses cdrskin in place of cdrecord.",
True, and there's one thing I don't understand about that:
The dialog is only shown if you have cdrecord installed, but not with wodim (which is supposed to be inferior to cdrecord). I suppose I'll file a bug report upstream about that... ;-)
so I believe cdrskin should be required and cdrecord could be suggested or removed all together.
If we require cdrskin, it's not even possible to use cdrecord or wodim any more I think, so it doesn't make sense to suggesting it too IMHO.
I'm just wondering if we should require cdrskin at all?
People may want to use cdrecord or wodim for whatever reason, which seems not to be possible if cdrskin is installed.
Personally I never had any problem with cdrecord (or even wodim, for that matter), so I don't really see a reason to install cdrskin in addition to it. (I think cdrecord or wodim are already pulled in by the standard patterns too)
A recommends would allow to not install cdrskin and use cdrecord or wodim instead.
But again, I don't really have a strong opinion on that.
I'll leave this decision to somebody else... ;-)
Probably a matter of taste anyway.
As for whether or not cdrskin uses those tools, I'm not sure. From looking at the home page, it does seem to use mkisofs.
I think the question is not whether cdrskin uses them (in that case cdrskin should recommend/require them anyway), but whether k3b uses them if cdrskin is installed/used.
As the discussion in the bug report seems to tend more towards sticking with cdrecord, I submitted SR#512680 to disable that message about cdrskin/libburn.
I think it's the "better" (at least more conservative) approach, people who do prefer cdrskin can still install it and it will be used by k3b.
We can of course still decide to switch to it by default (or mandatory) later on as well.
But I'll let my fellow team members decide which SR to accept...
I did some tests myself:
burning works fine with cdrecord and wodim.
With cdrskin installed, k3b still seems to use cdrecord (not cdrskin), uninstalling cdrecord shows a message about cdrecord missing and breaks burning completely (even though cdrskin is installed).
So, this change doesn't make sense (currently), sorry.
Well, it supports both (and prefers cdrskin if installed I think). So I'm not sure if a Requires is really necessary here...
Though I'm not strictly against it either.
Unrelated to that, have you checked whether the other cdrecord/cdrkit tools (mkisofs, dvd+rw-tools, readcd) are still required/used with cdrskin? Or could they be removed too if we require cdrskin?
When you start k3b without cdrskin, a message pops up that states "K3b uses cdrskin in place of cdrecord.", so I believe cdrskin should be required and cdrecord could be suggested or removed all together.
As for whether or not cdrskin uses those tools, I'm not sure. From looking at the home page, it does seem to use mkisofs. Cdrskin seems to use libburn as a backend, so that would be a good place to look. I'll look into it further.
True, and there's one thing I don't understand about that: The dialog is only shown if you have cdrecord installed, but not with wodim (which is supposed to be inferior to cdrecord). I suppose I'll file a bug report upstream about that... ;-)
If we require cdrskin, it's not even possible to use cdrecord or wodim any more I think, so it doesn't make sense to suggesting it too IMHO.
I'm just wondering if we should require cdrskin at all? People may want to use cdrecord or wodim for whatever reason, which seems not to be possible if cdrskin is installed.
Personally I never had any problem with cdrecord (or even wodim, for that matter), so I don't really see a reason to install cdrskin in addition to it. (I think cdrecord or wodim are already pulled in by the standard patterns too)
A recommends would allow to not install cdrskin and use cdrecord or wodim instead.
But again, I don't really have a strong opinion on that. I'll leave this decision to somebody else... ;-)
Probably a matter of taste anyway.
I think the question is not whether cdrskin uses them (in that case cdrskin should recommend/require them anyway), but whether k3b uses them if cdrskin is installed/used.
@Vogtinator, @alarrosa, @luca_b, @tittiatcoke, @wolfi323: review reminder
Well, we just got a bug report about that issue, but that sounds to me rather like a complaint about k3b using cdrskin at all: https://bugzilla.opensuse.org/show_bug.cgi?id=1050715
So I'm currently even less sure we should accept this, maybe we should rather patch out that message.
FYI, Dave Plater (the reporter) is a long-standing multimedia maintainer in openSUSE.
As the discussion in the bug report seems to tend more towards sticking with cdrecord, I submitted SR#512680 to disable that message about cdrskin/libburn.
I think it's the "better" (at least more conservative) approach, people who do prefer cdrskin can still install it and it will be used by k3b.
We can of course still decide to switch to it by default (or mandatory) later on as well.
But I'll let my fellow team members decide which SR to accept...
I did some tests myself: burning works fine with cdrecord and wodim.
With cdrskin installed, k3b still seems to use cdrecord (not cdrskin), uninstalling cdrecord shows a message about cdrecord missing and breaks burning completely (even though cdrskin is installed).
So, this change doesn't make sense (currently), sorry.