Request 532417 (superseded)

This request is superseded by request 533650 (Show diff)

Overview

Request 532417 superseded

- sysusers2shadow.sh: Exit if one of the useradd/groupadd/usermod
call fails: the resulting system is quite undefined if this
should happen.
- sysusers-generate-pre: exit the pre script with the exit code
of sysusers2shadow.sh.

Created by msmeissn over 6 years ago
In state superseded
Supersedes 532405
Superseded by 533650
Open review for opensuse-review-team
Open review for repo-checker
Open review for factory-staging

Submit sysuser-tools

Comments for request 532417 2
Comments for request 532405 1

Dominique Leuenberger (dimstar) - over 6 years ago

reviewer

Grmbl".. Even though this change would be correct, we get ourselves into even more trouble - as while building sysuser-tools, sysuser-tools is not in the buildroot and thus the script itself is missing...

We could workaround this by enhancing the generated pre script, and acceptimg to skip if .buildenv exists but no /usr/sbin/sysuser2shadow... The resulting buildroot would be the same as before, with the difference that this very package could be built

Dominique Leuenberger (dimstar_suse) - over 6 years ago

reviewer target maintainer

Needs some more thought to get it right

Dominique Leuenberger (dimstar) - over 6 years ago

reviewer

-echo "exit 0"
+echo "exit $?"

Thinking about this - this is wrong: $? needs to be escaped (or the 'echo command' will already replace it with the output of the previous 'echo' - hence '0' again