Overview
Request 541912 superseded
- Remove migration code for the v1.9.x -> v1.10.x migration. This has been
around for a while, and we no longer support migrating from such an old
version "nicely". Docker still has migration code that will run on
first-boot, we are merely removing all of the "nice" warnings which tell
users how to avoid issues during an upgrade that ocurred more than a year
ago.
- Created by cyphar
- In state superseded
-
Package maintainer:
cyphar
- Supersedes 541910
- Superseded by 545109
Request History
cyphar created request
- Remove migration code for the v1.9.x -> v1.10.x migration. This has been
around for a while, and we no longer support migrating from such an old
version "nicely". Docker still has migration code that will run on
first-boot, we are merely removing all of the "nice" warnings which tell
users how to avoid issues during an upgrade that ocurred more than a year
ago.
superseded by 545109
@cyphar, @jordimassaguerpla: review reminder
LGTM
Why the change in line 53 and 128?
53 was previously wrong (or rather, it wasn't correctly used elsewhere -- /usr/lib/docker was used before but not anymore). But we need to add /var/lib/docker (%_localstatedir). 128 means that now we won't accidentally package files inside /var/lib/docker (something our migration code did after maintainence changed it).
What about line 13? update_messages is not being used in this spec file anyway. Do we need to add that?
I added it so we remember where's the right place to add messages in the future -- but I guess we'll just remember next time we have to deal with this issue.
Ok. I see you did it on purpose. LGTM