Overview
Request 544586 accepted
- Add 0001-build-support-scons-python3.patch: Support scons running
with python3 as interpreter.
- Conditionalize the openSUSE post/postun scripts for suse_version
< 1330 only: newer versions handle the icon theme cache by means
of file triggers.
Request History
dimstar created request
- Add 0001-build-support-scons-python3.patch: Support scons running
with python3 as interpreter.
- Conditionalize the openSUSE post/postun scripts for suse_version
< 1330 only: newer versions handle the icon theme cache by means
of file triggers.
gnome-review-bot accepted review
Check script succeeded
yfjiang accepted review
I see, thank you for the clarification. Look good since it proactively implements upstream feature in a easier way, and the patch looks safe to me.
yfjiang approved review
I see, thank you for the clarification. Look good since it proactively implements upstream feature in a easier way, and the patch looks safe to me.
dimstar accepted request
@dimstar, just a clarification for future handling of gpick, when I tried to check the upstream status of the patch, I failed to find the PR/commit in https://github.com/thezbyg/gpick Is it the right place to check the upstream of this particular package? Thank you!
yes - this is a feature to be fixed by upstream, bit looking at their git they already did a lot of work to get there. But with too many unrelated changes to the build system, it was close to impossible to collet the relevant commits (It was much easier to just write a patch for now) - the patch is still tagged upstream as we do not intend to carry it forever (future versions likely already allow us to drop it)
@dimstar: review reminder