Overview
Request 572450 accepted
- Avoid bashisms in test-driver:
* 0001-correct-parameter-parsing-in-test-driver-script.patch
Use test's = operator instead of ==; use '[' instead of '[['.
This avoids 'make check' failures of distribution tarballs (built on
openSUSE) on platforms not supporting bashisms, e.g. NetBSD-7.1.
Request History
berny created request
- Avoid bashisms in test-driver:
* 0001-correct-parameter-parsing-in-test-driver-script.patch
Use test's = operator instead of ==; use '[' instead of '[['.
This avoids 'make check' failures of distribution tarballs (built on
openSUSE) on platforms not supporting bashisms, e.g. NetBSD-7.1.
pluskalm declined request
Declining per comment.
berny reopened request
Because I am (and probably also some others, too, are) maintaining upstream projects - which obviously do not aim at openSUSE/SUSE only.
I personally find it quite scary that we have such a patch in openSUSE
which then silently meanders into upstream tarballs. IMO you could
also drop the whole patch ... or take it upstream.
pluskalm declined request
Then please push patch to upstream. As for openSUSE we should probably drop it. What exactly "silently meanders into upstream tarballs?"
berny reopened request
> Then please push patch to upstream.
well, no. For automake, I'm neither the upstream nor the downstream maintainer. I just contributed here because I was accidentally bitten by ... see below.
> As for openSUSE we should probably drop it.
your choice - you're the downstream maintainer.
> What exactly "silently meanders into upstream tarballs?"
I want to make a new cut for the GNU findutils. During the local build, automake copies the test-driver from /var/share/... into 'build-aux/' which is then copied into the distribution tarball during 'make dist'. Platform tests on BSD systems then fail because
of the bashisms.
Isn't the patch trivial enough to ACK?
pluskalm accepted request
Ok then
"This avoids 'make check' failures of distribution tarballs (built on openSUSE) on platforms not supporting bashisms, e.g. NetBSD-7.1" - why is that relevant for openSUSE?
I am not in favor of adding patches that have no merit from openSUSE's point of view.