Overview
Request 583714 superseded
- Fixed issues in first commit
* modified spec file
* created changes file
* patched upstream script to avoid following rpmlint warning:
* papirus-folders.noarch: E: env-script-interpreter
* (Badness: 9) /usr/bin/papirus-folders /usr/bin/env bash
- Created by DarthWound
- In state superseded
- Package maintainer: andythe_great
- Supersedes 573940
- Superseded by 584566
@dirkmueller, @keichwa, @mkudlvasr, @mseben, @sbrabec, @vuntz: review reminder
Please also create a .changes file using osc vc
, documenting packaging and upstream changes (for future updates)
-
Release:
is by definition just set to0
(it is managed by OBS) -
%changelog
section is not to be maintained inside the .spec file - Why
BuildRequires: automake
? There seems no need, as there is no autbuilld system in use -
BuildRequires: coreutils
is not wrong per se, but is implicit in any build root - The source should be specified as a full URL, as its 'cleanlyness' compared to what upstream provides is not easily verifiable. If it's a git checkout, consider using a obs_scm source service
- Consider fixing the rpmlint warning: papirus-folders.noarch: E: env-script-interpreter (Badness: 9) /usr/bin/papirus-folders /usr/bin/env bash
Thank you @dimstar, new request is here: https://build.opensuse.org/request/show/583714
PS: should I answer in mailing-list thread as well?
Request History
DarthWound created request
- Fixed issues in first commit
* modified spec file
* created changes file
* patched upstream script to avoid following rpmlint warning:
* papirus-folders.noarch: E: env-script-interpreter
* (Badness: 9) /usr/bin/papirus-folders /usr/bin/env bash
Fixed issues detailed by @dimstar.
Package test on my Tumbleweed desktop: OK
Is version really "v0.0.3" not 0.0.3?
If we follow upstream, yes: https://github.com/PapirusDevelopmentTeam/papirus-folders/releases/tag/v0.0.3
https://github.com/PapirusDevelopmentTeam/papirus-folders/blob/master/debian/changelog says otherwise
Ok, I fixed that and submitted a new request: https://build.opensuse.org/request/show/584566