Overview
Request 599808 revoked
- change shortname and remove Provides to avoid conflicts
- change spec and changes file to be same as package name
- version 0.0.45
- version 0.0.44
- version 0.0.41
- version 0.0.39
- added libc++1 dep
- version 0.0.36
- version 0.0.35
- Added non patent encumbered ffmpeg
- forked a canary build
- canary version 0.0.32
- Update to version 0.0.2.
- Move application files to %{_libdir} instead of %{_data_dir}
to avoid arch-dependent-file-in-usr-share (Badness: 590).
- Remove patchelf and rpmlintrc as they are no longer required.
- Update description
- Enforce bash for building for extglob
- Initial package.
- Created by simonizor
- In state revoked
-
Package maintainer:
moozaad
-
Open review for
boombatower
Request History
simonizor created request
- change shortname and remove Provides to avoid conflicts
- change spec and changes file to be same as package name
- version 0.0.45
- version 0.0.44
- version 0.0.41
- version 0.0.39
- added libc++1 dep
- version 0.0.36
- version 0.0.35
- Added non patent encumbered ffmpeg
- forked a canary build
- canary version 0.0.32
- Update to version 0.0.2.
- Move application files to %{_libdir} instead of %{_data_dir}
to avoid arch-dependent-file-in-usr-share (Badness: 590).
- Remove patchelf and rpmlintrc as they are no longer required.
- Update description
- Enforce bash for building for extglob
- Initial package.
moozaad added boombatower as a reviewer
Hi Boomatower
Have a quick look at this please. I would like a third party opinion.
The simonizor doesn't like the artificial conflict (discord vs discord canary) and wants to be able to install multiple versions at once.
My counter arguments were A) user simplicity, B) historically there have been conflicts between canary and stable (iirc last bug was canary writing to stable dir bug last autumn '17 and was quickly fixed - discord doesn't do changelogs to verify).
I don't however strongly disagree to this change. Those installing canary from a community repo should know there's some risk involved.
Regards,
mooz
simonizor revoked request
Resubmitting with Conflicts line removed
Diff for the lazy. Only spec issue I see is that I forgot to update the copyright back in Jan
diff discord.spec discord-canary.spec 2c2 < # spec file for package discord --- > # spec file for package discord-canary 37,39c37,38 < Provides: discord < Conflicts: discord < %define shortname discord --- > Conflicts: discord-canary > %define shortname discord-canary 76,77c75,76 < install -Dm755 libffmpeg.so %{buildroot}%{_libdir}/discord/libffmpeg.so < install -Dm755 libnode.so %{buildroot}%{_libdir}/discord/libnode.so --- > install -Dm755 libffmpeg.so %{buildroot}%{_libdir}/%{shortname}/libffmpeg.so > install -Dm755 libnode.so %{buildroot}%{_libdir}/%{shortname}/libnode.so 102a102 >What is the point of:
Unless multiversion() is used (like for kernel) is this even possible?
As for the discussion around allowing canary and stable installed at same time this comes down to a maintainer preference and if the packaging can easily support it. For example, wine conflicts with wine-staging, wine-staging-nine, and wine-nine, but obviously one could change packaging to allow all to be installed.
It seems based on use of %shortname that things are already setup to support canary along-side stable. As such if not one is opposed and upstream supports I'm fine with it.
The change in spec name to match package makes sense for consistency. The request description would be better to only include the first two bullets.
If anything it might be handy to add a warning to description although most will likely never read.
Discord does not conflict with any other version of itself. The config directories are all stored in separate places. The install directories are all different by default. All versions of Discord can be installed at the same time.
As for the Conflicts: line, I wasn't sure what to put there.
Would you like me to remove the Conflicts line or is it fine as is?
Yes, should just remove it.