Overview

Request 606948 accepted

submit new version 15.0.13


Leap Reviewbot's avatar

YaST:openSUSE:15.0/skelcd-control-openSUSE@16 -> openSUSE:Leap:15.0/skelcd-control-openSUSE

expected origin is 'FORK' (unchanged)

the submitted sources are NOT in Factory


Leap Reviewbot's avatar

YaST:openSUSE:15.0/skelcd-control-openSUSE@1 -> openSUSE:Leap:15.0/skelcd-control-openSUSE

expected origin is 'Devel;YaST:openSUSE:15.0;skelcd-control-openSUSE' (unchanged)

sr#532181 to openSUSE:Factory has different sources

the submitted sources are NOT in Factory


Leap Reviewbot's avatar

YaST:openSUSE:15.0/skelcd-control-openSUSE@4 -> openSUSE:Leap:15.0/skelcd-control-openSUSE

expected origin is 'FORK' (unchanged)

the submitted sources are NOT in Factory


Yuchen Lin's avatar

cause no swap partition created


Yuchen Lin's avatar

does not create swap partition


Richard Brown's avatar

it does create a swap partition - the failure is nothing to do with this PR, but a bug in YaST that doesn't make a swap file when changing the filesystem from btrfs


Richard Brown's avatar

bug is https://bugzilla.opensuse.org/show_bug.cgi?id=1078495 yast team's trello board https://trello.com/c/mzxn9DzB


Ludwig Nussel's avatar

If yast doesn't fix it this week, please consider resubmitting with the proposed_configurable to enforce swap always setting.


Richard Brown's avatar

I'll consider it - but I really done like it - that will mean users will not be able to have a swapless system without going into the expert partitioner.

Can you persuade me? or make me feel better about that? :-/


Ludwig Nussel's avatar

Of course the goal is to have this fixed but we also want the new subvolume layout ASAP.


Ludwig Nussel's avatar

According to the bug report there is no fix expected this week. So I'd prefer to have the new subvolume layout now and then fix the swap setting later again.


Richard Brown's avatar

https://github.com/yast/skelcd-control-openSUSE/pull/113

Reluctantly agreed - now it's down to the YaST team to get this to factory so you can accept both a new skelcd and this


Leap Reviewbot's avatar

YaST:openSUSE:15.0/skelcd-control-openSUSE@5 -> openSUSE:Leap:15.0/skelcd-control-openSUSE

expected origin is 'FORK' (unchanged)

the submitted sources are NOT in Factory



Richard Brown's avatar

It’s not unexpected - disabling the configuration of swap was bound to cause other bugs

I guess it’s your choice which to ignore

In my opinion it’s essential Leap 15 gets the flat /var, the entire package family has been configured for it - so you can have 15.0.2 version of this package

The swap glitch which non default file systems probably should be raised with the YaST team given we can’t workaround it


Ludwig Nussel's avatar

the raid test does create a swap partition, just with 400MB size. Why does yast insist in 1GB?


Ludwig Nussel's avatar

and why does it work in sle? or doesn't it?


Richard Brown's avatar

it intests in 1GB because that is precisely what you told me to do ;)

By making swap non-configurable in the control.xml to work around the bug with swap-on-non-default-fs, YaST now has a hard requirement that every swap partition must be at least 1GB

The raid test failure seems to be proving that my reluctance about disabling swap configuration was justified.

SLE and Tumbleweed have no tests that notice the swap-on-non-default-fs problems. The problem is the same there, but it has been going unnoticed.


Ludwig Nussel's avatar

sigh we were talking about the proposal and the option "proposed_configurable" strongly hints that this is related to what yast proposes. That this option als has the side effect of enforcing some minimum size on a manually created, custom partition layout is all but obvious. iow wtf? :)


Richard Brown's avatar

The custom partitioner is just going to make a custom proposal - so with that logic I can understand YaST's confusion - IIRC normally we wouldn't even have the custom partitioner if we were limiting the proposals in this way.


Leap Reviewbot's avatar

YaST:openSUSE:15.0/skelcd-control-openSUSE@10 -> openSUSE:Leap:15.0/skelcd-control-openSUSE

expected origin is 'FORK' (unchanged)

sr#595492 to openSUSE:Factory has different sources

the submitted sources are NOT in Factory


Leap Reviewbot's avatar

YaST:openSUSE:15.0/skelcd-control-openSUSE@15 -> openSUSE:Leap:15.0/skelcd-control-openSUSE

expected origin is 'FORK' (unchanged)

the submitted sources are NOT in Factory

Request History
Imobach Gonzalez Sosa's avatar

IGonzalezSosa created request

submit new version 15.0.13


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Leap Reviewbot's avatar

leaper added leap-reviewers as a reviewer


Leap Reviewbot's avatar

leaper added opensuse-review-team as a reviewer


Leap Reviewbot's avatar

leaper added legal-auto as a reviewer


Leap Reviewbot's avatar

leaper accepted review

ok


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar accepted review


Staging Bot's avatar

staging-bot added openSUSE:Leap:15.0:Staging:F as a reviewer

Being evaluated by staging project "openSUSE:Leap:15.0:Staging:F"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Leap:15.0:Staging:F


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Ludwig Nussel's avatar

lnussel accepted review


Ludwig Nussel's avatar

lnussel_factory accepted review

ready to accept


Ludwig Nussel's avatar

lnussel_factory approved review

ready to accept


Ludwig Nussel's avatar

lnussel_factory accepted request

Accept to openSUSE:Leap:15.0

openSUSE Build Service is sponsored by