Overview

Request 618448 superseded

- Add accountsservice-lib-treat-session-type-wayland-as-graphical-session.patch:
When user session type is wayland, act_user_is_logged_in can
return TRUE if the user is logged in (boo#1095918 fdo#106855).


Felix Zhang's avatar

Thanks for the submission, could you please submit to Factory first?



Cliff Zhao's avatar

I saw that upstream has already accepted your request, so, I'm wondering if it is better to update or backport this patch, that will be easy to maintain. Thanks. And Your patch and log format are fine for me except for some grammar error. :-)


Felix Zhang's avatar

Sorry, I'm just watching from aside but the patch is exactly the upstream commit backported (check the upstream git log).

And could you please refer to the grammar errors please? Thanks!


Cliff Zhao's avatar

If this patch is a backport, it's better to explain this in the spec file or the changelog. return TRUE if user is logged in (the user... or usrs...)


Felix Zhang's avatar

The patch is tagged as -UPSTREAM in spec file and also with fdo# ref in both specfile and changelog.

And thanks for being explicit about the grammar stuff.

Anyway, I personally prefer to submit to G:F first whenever relevant where we get reviews from the veterans. :-)

Request History
xiaoguang wang's avatar

xiaoguang_wang created request

- Add accountsservice-lib-treat-session-type-wayland-as-graphical-session.patch:
When user session type is wayland, act_user_is_logged_in can
return TRUE if the user is logged in (boo#1095918 fdo#106855).


xiaoguang wang's avatar

xiaoguang_wang superseded request

superseded by 623938

openSUSE Build Service is sponsored by