Overview

Request 625336 superseded

No description set
Loading...

Alexander Graul's avatar

I've send an annoucement mail to factory about this package https://lists.opensuse.org/opensuse-factory/2018-07/msg00193.html


Ismail Dönmez's avatar

@agraul Just build against :Update for Leap/SLE and you can use %license everywhere.


Dominique Leuenberger's avatar

As he builds just the same as is in the project utilities, not much of his choice there


Ismail Dönmez's avatar

I updated the project config.


Dominique Leuenberger's avatar
+%if ( 0%{?suse_version} == 1315 && 0%{?sle_version} <= 120200 ) || ! 0%{?is_opensuse}

That would also negatively impact SLE15 packages

Either use only %license or make the condition less error prone like this:

%if 0%{?suse_version} >= 1500
  %license LICENSE.md
%else
  %doc LICENSE.md
%endif

Dominique Leuenberger's avatar
+# MANUAL BEGIN
+Requires:       bash >= 3.2
+# MANUAL END

This should not be needed - by having a shebang pointing to /bin/bash (which you have, due to fix-shebang.patch), the rpm get's an automatic dependency on /bin/bash - which in turn is provided by the package bash (the only downside there being it not versioned, but openSUSE used bash 4.0 since 2009; so I'd say this is safe to be ignored)


Alexander Graul's avatar
author source maintainer

thanks a lot for the comments and thanks to @namtrac for the SR :)

Request History
Alexander Graul's avatar

agraul created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Staging Bot's avatar

staging-bot added openSUSE:Factory:Staging:adi:54 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:54"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:adi:54


Repo Checker's avatar

repo-checker accepted review

cycle and install check passed


Ismail Dönmez's avatar

namtrac declined review

https://build.opensuse.org/request/show/625789


Ismail Dönmez's avatar

namtrac declined request

https://build.opensuse.org/request/show/625789


openSUSE Build Service is sponsored by