Overview
Request 631019 superseded
GNU dbm 1.18 (forwarded request 630977 from AndreasStieger)
- Created by pgajdos
- In state superseded
- Superseded by 645670
- Open review for repo-checker
- Open review for openSUSE:Factory:Staging:C
Request History
pgajdos created request
GNU dbm 1.18 (forwarded request 630977 from AndreasStieger)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
namtrac accepted review
dimstar_suse set openSUSE:Factory:Staging:A as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:A"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:A
dimstar_suse set openSUSE:Factory:Staging:C as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:C"
dimstar_suse accepted review
Moved to openSUSE:Factory:Staging:C
superseded by 645670
Breaks perl:
CC @mlschroe
Indeed, for local build I get:
https://rt.perl.org/Public/Bug/Display.html?id=133295 https://puszcza.gnu.org.ua/bugs/index.php?399
Apologize I understand the issue only marginally.
If I understand correctly, the test closes descriptor underneath GDM_File and waiting gdbm to error out. For the reasons explained in both bugs, gdbm_STORE() (i. e. gdm_store(), $h{Perl} = 'Rules';), does not sync immediately anymore already for some time and thus the error does not pop up. It could be raised during gdbm_DESTROY (untie %h;), but gdm_close() is void and cannot report an error.
This is fixed by http://git.gnu.org.ua/cgit/gdbm.git/commit/?id=030e685eb9df82f63d73a1bf206da84b7aa52374, and this is already part of gdbm 1.18.
I think now it is perl side which has to be fixed, that means GDBM_File.xs' gdbm_DESTROY(db) has to check return value of gdbm_close(db); and propagate error.
I guess the result of the test could be ignored for now.
see rq#632290
@dimstar_suse, @factory-repo-checker: review reminder