You should use LD_LIBRARY_PATH=%{buildroot}{_libdir}, as you want to test the installed libraries.

Please add a line to the changelog stating the "basic" tests are now enabled.

The libraries should be packaged separately, according to the shared library policy. libeccodes has outside users.

Also remove build_for_scienceproject, it is not necessary.

@manfred999 - can you please address the other two issues?

Also, hdf5_1_8-devel no longer exists, please remove the references to it from the specfile.

LD_LIBRARY_PATH: thanks for the hint, testing the installed version is better. changelog: I updated the changelog for the added tests. Library packaging: ECMWF refuses to do so-versioning and does not give any guaranties for their API. Mostly it is not an issue as the API is quite stable, but nevertheless. Outside users are mostly left alone. Therefore I hesitate to split the package. But it could be done, of course. build_for_scienceproject: I agree it is ugly. It was my attempt to efficiently have packages in default environment (which I have to do) and in science project environment. hdf5_1_8 is no issue for the science project, as it is in the else clause of build_for_scienceproject. Are such constructs not accepted in the science project?

@manfred999: review reminder