Overview

Request 668714 superseded

- Add a patch to fix the problem with AWSHTTPSConnection
constructor override. (bsc#1122359)
+ patch is taken from https://github.com/boto/botocore/pull/1259


Colleen Murphy's avatar

I think the bsc# may need to be on the first line instead of linewrapped, otherwise lgtm


Dirk Mueller's avatar

it can be anywhere (we usually do put it on the first line, but that isn't a requirement)


Dirk Mueller's avatar

the important part here is that the patch filename is literally (!) mentioned in the .changes file..


Colleen Murphy's avatar

Not sure how important it is but it might be better if the patch was formatted directly from the upstream commit https://github.com/boto/botocore/pull/1259/commits/ac5cf81e854b6c1aa77f38f8c934c96d859f6c39 so that it gives proper attribution to the original author?


Colleen Murphy's avatar

Also the changelog needs the bsc #

Request History
Guang Yee's avatar

yeey created request

- Add a patch to fix the problem with AWSHTTPSConnection
constructor override. (bsc#1122359)
+ patch is taken from https://github.com/boto/botocore/pull/1259


Dirk Mueller's avatar

dirkmueller declined request

see comments


Guang Yee's avatar

yeey superseded request

superseded by 669120

openSUSE Build Service is sponsored by