Overview
Request 674168 superseded
tweak changes file
- Created by smithfarm
- In state superseded
- Supersedes 674156
- Superseded by 678238
- Open review for openSUSE:Factory:Staging:adi:163
Request History
smithfarm created request
tweak changes file
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
staging-bot added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:163"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:163
repo-checker accepted review
cycle and install check passed
dimstar declined request
+BuildRequires: systemd
This is already covered by pkgconfig(systemd) - which is covered by systemd and systemd-mini. BuildRequiring systemd is a bad choice, as it puts your package way back in the line (you can just drop it, or if needed, put it in the non-suse branch of the spec)
superseded by 678238
+%if 0%{?is_opensuse} +BuildRequires: openSUSE-release +%else +BuildRequires: sles-release +%endifYou should be able to do
BuildRequires: distribution-releaseMuch better, and help this package get out from a massive rebuild as sles-release and openSUSE-release are frequently rebuilt.
+BuildRequires: systemd
This is already covered by pkgconfig(systemd) - which is covered by systemd and systemd-mini. BuildRequiring systemd is a bad choice, as it puts your package way back in the line (you can just drop it, or if needed, put it in the non-suse branch of the spec)