Overview

Request 688046 superseded

Thanks for the review Stefan. I adjusted everything according to your feedback :)

I just let the COPYING file in the geda-gaf as I think it fits there better together with the README and the NEWS file.

If you still want to have it in geda-base, feel free to accept the SR and change it afterwards :)

Loading...

Stefan Brüns's avatar

Fails to build, you still install the COPYING manually into the %_docdir

The reason for putting the COPYING into the base package is to have it installed as soon as any other part is installed.


Stefan Brüns's avatar

Thanks for working on this, some remarks:

Changelog:

  • Sentences should start with a capital letter
  • Check indentation for continued lines
  • Strange entry "backends.", third line

  • %defattr is obsolete, just remove it

  • COPYING should be part of base, and use the %license macro

Request History
Jonathan Brielmaier's avatar

jbrielmaier created request

Thanks for the review Stefan. I adjusted everything according to your feedback :)

I just let the COPYING file in the geda-gaf as I think it fits there better together with the README and the NEWS file.

If you still want to have it in geda-base, feel free to accept the SR and change it afterwards :)


Stefan Brüns's avatar

StefanBruens declined request


openSUSE Build Service is sponsored by