Looks fine, except for the usual changelog nitpicks...

extra-cmake-modules:
+ * Revert "Take clang-cl into account"
+ * Take clang-cl into account

frameworkintegration:
+ * It compiles find without foreach
...compiles fine...

kdeclarative:
+ * Revert "export implicitCellWidth/height at top level"
+ * export implicitCellWidth/height at top level

khtml:
+ * Remove deprecated method
+ * Remove deprecated methods (the first one can be removed I think)

knotifications:
+ * Comment for the moment as it's broken because it uses phonon
???
(to clarify, the "add_definitions(-DQT_NO_FOREACH)" line added by the previous change was commented out because it didn't actually build with it, so I'd probably just remove this line...)

kparts:
+ * [kparts] compile without foreacg
"foreach"

I'd just change those after it has been accepted though.

Luca Beltrame (luca_b) - about 5 years ago

author target maintainer

FTR, at least to reduce spam I started filter commits with NO_CHANGELOG in (see the discussion in k-f-d). I hope this will reduce issues in the future.

Any other objections? I'd like to push this before Thursday so I can focus on the Applications 19.04 release.

Not an objection, but kglobalaccel 5.57 has a regression: https://bugs.kde.org/show_bug.cgi?id=406426

We should better add the fix I think, at least before this is submitted to Factory:
https://cgit.kde.org/kglobalaccel.git/commit/?id=abe32ec599397bda0ce73471519410bee2c16059

Wolfgang Bauer (wolfi323) - about 5 years ago

target maintainer

And it seems that kpackage has a similar problem:
https://cgit.kde.org/kpackage.git/commit/?id=c3e896e02f9a8dc92d6e26cdbc87fe5c6b9cf3bf