Request 731533 (superseded)

This request is superseded by request 750757 (Show diff)

Overview

Request 731533 superseded

No description set

Created by M0ses over 4 years ago
In state superseded
Superseded by 750757
Open review for openSUSE:Factory:Staging:G

Submit createrepo_c

Comments for request 731533 6

Frank Schreiner (M0ses) - over 4 years ago

author source maintainer

For a proper building of the media's this SR depends on the following SR's, which cleanup control characters in the changelogs:

https://build.opensuse.org/request/show/731498 https://build.opensuse.org/request/show/731493 https://build.opensuse.org/request/show/731489 https://build.opensuse.org/request/show/731485 https://build.opensuse.org/request/show/731484 https://build.opensuse.org/request/show/731483

Dominique Leuenberger (dimstar) - over 4 years ago

reviewer

[  181s] Oct-03 07:52:50 <1> : [I] Executing command <createrepo_c --unique-md-filenames --excludes=boot/*.rpm --excludes=boot/*/*.rpm --checksum=sha256 --no-database --error-exit-val --repo="obsproduct://build.opensuse.org/openSUSE:Factory:Staging:L/openSUSE/1/x86_64" --distro="cpe:/o:opensuse:opensuse:1,openSUSE Tumbleweed" /usr/src/packages/KIWIROOT/main/openSUSE-Tumbleweed-DVD-x86_64-Build165.1-Media>
[  217s] Oct-03 07:53:26 <3> : [E] Called <createrepo_c --unique-md-filenames --excludes=boot/*.rpm --excludes=boot/*/*.rpm --checksum=sha256 --no-database --error-exit-val --repo="obsproduct://build.opensuse.org/openSUSE:Factory:Staging:L/openSUSE/1/x86_64" --distro="cpe:/o:opensuse:opensuse:1,openSUSE Tumbleweed" /usr/src/packages/KIWIROOT/main/openSUSE-Tumbleweed-DVD-x86_64-Build165.1-Media> exit status: <2> output: Directory walk started
[  217s] Directory walk done - 3519 packages
[  217s] Temporary output repo path: /usr/src/packages/KIWIROOT/main/openSUSE-Tumbleweed-DVD-x86_64-Build165.1-Media/.repodata/
[  217s] Pool started (with 5 workers)
[  217s] Pool finished with errors
[  217s] Warning: There were some invalid packages: we have to recompress other, filelists and primary xml metadata files in order to have correct package counts
[  217s] 
[  217s] lamb25 failed "build openSUSE-dvd5-dvd-x86_64.kiwi" at Thu Oct  3 07:53:26 UTC 2019.

This is, mildly spoken, a useless error message as it gives no hint as to what went wrong

Dominique Leuenberger (dimstar) - over 4 years ago

reviewer

I'm very worried with this change - IMHO, create-repo should 'accept garbage' as good as it can - and not discard the entire distro for it

We have no idea what all is going to be broken and how long it will take to get all the issues fixed that would be seen by createrepo_c now.

(in Staging, it reports two errors left, one of them has a fix submitted to the devel prj - I pinged the maintainer there to get this moving)

Frank Schreiner (M0ses) - over 4 years ago

author source maintainer

The idea is to fix all packages in factory/tumbleweed and release createrepo_c afterwards. We are working a patch for OBS itself to support older distributions. IMHO the new behavior is absolutly correct as it forces package maintainers to fix their packages or otherwise break ASAP.

Maybe it would be a good idea to add checks to rpmlint.

Dominique Leuenberger (dimstar_suse) - over 4 years ago

reviewer target maintainer

Not ready - we first need a rpmlint/brp error barfing on changelog failures that would kill the product creation. Only failing on prod metadata creation puts all the strain on the RM, which is inacceptable

Frank Schreiner (M0ses) - over 4 years ago

author source maintainer

I already sent a SR: https://build.opensuse.org/request/show/737506 to fix the broken package

I also opened an issue upstream: https://github.com/rpm-software-management/rpmlint/issues/354