Overview

Request 759232 accepted

No description set
Loading...

Dominique Leuenberger's avatar

Breaks VLC and frei0r plugins


Dominique Leuenberger's avatar

VLC fails to build against this version of opencv3


Dominique Leuenberger's avatar

I wonder if the failure in VLC is intentional with this minor upgrade of opencv3:

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:M/vlc/standard/x86_64


Dominique Leuenberger's avatar
[  332s] ../doltlibtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I..  -DMODULE_STRING=\"$(p="video_filter/libopencv_example_plugin_la-opencv_example.lo"; p="${p##*/}"; p="${p#lib}"; p="${p%_plugin*}"; p=$(echo "$p"|sed 's/-/_/g'); p="${p%.lo}"; echo "$p")\" -D__PLUGIN__  -I./access -I./codec -I/usr/include/opencv  -I../include -I../include   -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -fno-common -Werror=return-type  -g -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wvolatile-register-var -Wformat -Wformat-security -fvisibility=hidden -O3 -fno-math-errno -funsafe-math-optimizations -fno-rounding-math -fno-signaling-nans -fcx-limited-range -funroll-loops -fomit-frame-pointer -c -o video_filter/libopencv_example_plugin_la-opencv_example.lo `test -f 'video_filter/opencv_example.cpp' || echo './'`video_filter/opencv_example.cpp
[  332s] In file included from /usr/include/opencv2/imgproc/imgproc.hpp:48,
[  332s]                  from video_filter/opencv_example.cpp:46:
[  332s] video_filter/opencv_example.cpp: In function 'picture_t* Filter(filter_t*, picture_t*)':
[  332s] video_filter/opencv_example.cpp:200:46: error: could not convert 'cv::Scalar_<double>((double)0, (double)0, (double)0, (double)0)' from 'cv::Scalar' {aka 'cv::Scalar_<double>'} to 'CvScalar'
[  332s]   200 |             cvRectangle( p_img[0], pt1, pt2, CV_RGB(0,0,0), 3, 8, 0 );
[  332s]       |                                              ^~~~~~
[  332s]       |                                              |
[  332s]       |                                              cv::Scalar {aka cv::Scalar_<double>}
[  332s] video_filter/opencv_example.cpp:204:59: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]
[  332s]   204 |             p_sys->event_info.p_region[i].p_description = "Face Detected";
[  332s]       |                                                           ^~~~~~~~~~~~~~~
[  332s] make[4]: *** [Makefile:24759: video_filter/libopencv_example_plugin_la-opencv_example.lo] Error 1
[  332s] make[4]: Leaving directory '/home/abuild/rpmbuild/BUILD/vlc-3.0.8/modules'
[  332s] make[4]: *** Waiting for unfinished jobs....
[  332s] make[4]: Entering directory '/home/abuild/rpmbuild/BUILD/vlc-3.0.8/modules'

and there, /usr/include/opencv2/imgproc/imgproc.hpp feels a bit confusing while only having opencv3 in the chroot - but well


Stefan Brüns's avatar

Somewhat (4.2.0): Breaking changes: Disabled constructors for legacy C API structures.

The same changes have been applied to 3.4.9.

The C API has been deprecated by the C++ API in openCV 2.0. This is also the reason it is located under /usr/include/opencv2.


Dominique Leuenberger's avatar

Unignored: returned to active backlog.

Request History
Stefan Brüns's avatar

StefanBruens created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Ismail Dönmez's avatar

namtrac accepted review


Dominique Leuenberger's avatar

dimstar_suse added openSUSE:Factory:Staging:D as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:D"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:D"


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:D"


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:M as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:M"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:M"


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:M"


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:M as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:M"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:M"


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:M"


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:I as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:I"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:I"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:I got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:I got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:I got accepted.

openSUSE Build Service is sponsored by