Overview

Request 761692 superseded

Adjustment for the dependency on hwdata from boo#1159838

Loading...

Dominique Leuenberger's avatar
[   45s] The Meson build system
[   45s] Version: 0.46.0
[   45s] Source dir: /home/abuild/rpmbuild/BUILD/libosinfo-1.7.1
[   45s] Build dir: /home/abuild/rpmbuild/BUILD/libosinfo-1.7.1/build
[   45s] Build type: native build
[   45s] 
[   45s] meson_options.txt:7:0: ERROR:  Unknown type feature.
[   45s] 
[   45s] A full log can be found at /home/abuild/rpmbuild/BUILD/libosinfo-1.7.1/build/meson-logs/meson-log.txt
[   45s] error: Bad exit status from /var/tmp/rpm-tmp.uOalaN (%build)

SLE15 and Leap 15.x build in your branch


Charles Arnold's avatar

I didn't see that building locally against 15-SP2 or Factory. I'm not sure how it is related to these changes.


Charles Arnold's avatar

For some strange reason, Leap 15.2 contains meson-0.46.0 Tumbleweed and SLE15-SP2 contains meson-0.51.2 Updating the meson in Leap 15.2 to the same version as SLE15-SP2 would probably resolve this error.


Dominique Leuenberger's avatar
 5-# Copyright (c) 2019 SUSE LLC
 6+# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany.

And this is wrong by definition - the correct current company name is SUSE LLC if I'm not all mistaken.


Charles Arnold's avatar

Bad merge on my part.


Dominique Leuenberger's avatar
28+%if 0%{?suse_version} >= 1550
29 BuildRequires:  hwdata
30+%endif

last but not least: I doubt Leap should follow SLE here. hwdata is kept up-to-date - the pci.ids in libosinfo are not up-to-date (the meson build script actually tries to download them nowadays - but obviously fails to do so in OBS

libosinfo contains:

  • pci.ids Version: 2016.10.03
  • usb.ids Version: 2016.09.29

whereas hwdata on TW currently comes with:

  • pci.ids Version: 2019.12.01
  • usb.ids Version: 2019.11.05

imho, this duplication of files is just wrong - and it would be much better to add hwdata to SLE15


Charles Arnold's avatar

Leap does not include this on the media (just like SLE). Adding hwdata to SLE15 SP2 would be nice. It may be too late in the release cycle to include it but I'll check. If so, I could just include the most recent pci.ids and usb.ids in the tarball with libosinfo.

Request History
Charles Arnold's avatar

charlesa created request

Adjustment for the dependency on hwdata from boo#1159838


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


openSUSE Build Service is sponsored by