Overview
Request 781648 accepted
update to 1.13.4; create directory /etc/telegraf/telegraf.d/
- Created by ojkastl_buildservice
- In state accepted
-
Package maintainers:
jfkw and
ojkastl_buildservice
- Supersedes 780563
Manuel or Nick, would you prefer to review before I accept the request? A word about the carried patch for Generic SQL output plugin being split up as part of this update:
The patch typically needs to be rebased for the README hunk only when telegraf updates are packaged, Johannes did the work to split up the patch to make editing easier and this is retained.
The upstream PR that is the source of this patch hasn't accepted it since 2018, with no recent activity. After accepting, I plan to make another change to drop the (now-split) patch.
telegraf-1.13.4 still uses the dep dependency tool. I anticipate an upcoming release will complete the transition to go modules, at which point the packaging will be updated accordingly.
Request History
ojkastl_buildservice created request
update to 1.13.4; create directory /etc/telegraf/telegraf.d/
jfkw accepted request
Accept to devel:languages:go
Superseded the old SR and only added "creating directory /etc/telegraf/telegraf.d/"
I will approve this today if there are no objections.
Hi Jeff, can you please accept this SR?
I also asked for maintainer rights for this package in SR788585..
Can someone please check this SR?
@mschnitzer, @nicksinger: review reminder
The patches should have tags - https://en.opensuse.org/openSUSE:Packaging_Patches_guidelines
Thanks Stefan!
it is in question if we should keep the patches. As Jeff wrote in SR#780563, upstream has not accepted those patches for a long time.
A word about the carried patch for Generic SQL output plugin being split up as part of this update: The patch typically needs to be rebased for the README hunk only when telegraf updates are packaged, Johannes did the work to split up the patch to make editing easier and this is retained. The upstream PR that is the source of this patch hasn't accepted it since 2018, with no recent activity. After accepting, I plan to make another change to drop the (now-split) patch.Accepted to preserve history. There will be a superseding SR shortly removing the patches which will not be accepted by upstream. Adding Johannes as a co-maintainer, and I'll remove other maintainers to simplify, which can easily be reverted if there is interest.