Loading...
Request History
paddg created request
Fix "invalid-license" Error
tkrizek declined request
Since there is a precedent for this change (I merged it in Knot DNS a while ago - https://gitlab.nic.cz/knot/knot-dns/-/merge_requests/1103 ), I'll use the opensuse license value for Knot Resolver as well. At least we'll be consistent.
I'll change this in the upcoming version - https://gitlab.nic.cz/knot/knot-resolver/-/merge_requests/1018
paddg revoked request
Ok, thanks a lot!
What is the rationale for this change?
The original value comes from https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_License_Short_Names
If OpenSUSE has different requirements then please provide a spec file which will fulfill requirements for Fedora and OpenSUSE at the same time.
This license string is not allowed on SLE_15_SP1. So I thought using the same as in home:CZ-NIC:knot-resolver-latest/knot/knot.spec could be fine for you as well
We use the same spec for both fedora/epel and opensuse. They both want different license string, so there's no right answer.
It would be possible to use macros to specify a different license string, but that just seems to increase the spec complexity for no good reason if this doesn't actually break anything.