Overview
Request 821470 accepted
- Ensure 'Provides: golang(API) = %{api_version}' is consistent
* Unify '{version'} and '{short_version}' as '{api_version}' for
'Provides: golang(API) = %{api_version}'
* Use both 'BuildRequires: go%{api_version}' and 'Requires: go%{api_version}'
to trigger build errors if go1.x is unavailable
* Add aarch64 to supported systems for go-race via
%define tsan_arch x86_64 aarch64
* Add tsan_arch x86_64 aarch64 for suse_version >= 1500 and
sle_version >= 150000, formerly conditional on suse_version >= 1315
* Ensure %ifarch %{tsan_arch} always evaluates (nil does not work)
via dummy tsan_arch on systems where go-race is not supported
- Enable for riscv64
- Update to current stable go1.14
Refs boo#1164903 go1.14 release tracking
* Remove redundant Provides: go-doc=%{version} per rpmlint warning
Thanks, I will review the broken builds.
Unignored: returned to active backlog.
I think sr#812040 should fix build issues you're likely to see from the Go metapackage.
This won't magically fix coredns:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:L/coredns/standard/x86_64
Yup, you're right -- I only saw the actual build errors after I commented. Looks like something is wrong with the vendoring setup (hence why go is trying to reach the internet during builds). Go 1.14 did change some of the Go module semantics, maybe that's what's going on.
Yes, starting with go1.13 upstream set as default the new community go package index/proxy/checksum infrastructure. https://golang.org/doc/go1.13#introduction .
Fortunately the controls remain for -mod=vendor for fully offline access needed inside OBS. There are also environment variables to make per-module specifications of proxy/noproxy/private that could be used to approximate fully-offline environments, but that seems brittle.
I will look at the breaking packages planning SRs to correct these.
https://golang.org/cmd/go/#hdr-Module_downloading_and_verification "Setting GOPROXY to "off" disallows downloading modules from any source." May also be useful for the decreasing number of upstream projects which have not yet migrated to modules.
What is the recommended environment to test go metapackage changes that break in certstrap, coredns, docker, etc. before forwarding an SR to Factory?
Would I copypac or link those into the home branch project where go metapackage changes are being developed, e.g. home:myuser:branches:devel:languages:go/{go,certstrap, coredns, docker} so they resolve the new go package for their respective builds?
branching them all together into one target would work, indeed
coredns seems to be the last failing package with this change
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:L/coredns/standard/x86_64
CCing coredns maintainer @mvedovati
go's meta package is bumping up to version 1.14, but coredns fails to build with this go version
Request History
jfkw created request
- Ensure 'Provides: golang(API) = %{api_version}' is consistent
* Unify '{version'} and '{short_version}' as '{api_version}' for
'Provides: golang(API) = %{api_version}'
* Use both 'BuildRequires: go%{api_version}' and 'Requires: go%{api_version}'
to trigger build errors if go1.x is unavailable
* Add aarch64 to supported systems for go-race via
%define tsan_arch x86_64 aarch64
* Add tsan_arch x86_64 aarch64 for suse_version >= 1500 and
sle_version >= 150000, formerly conditional on suse_version >= 1315
* Ensure %ifarch %{tsan_arch} always evaluates (nil does not work)
via dummy tsan_arch on systems where go-race is not supported
- Enable for riscv64
- Update to current stable go1.14
Refs boo#1164903 go1.14 release tracking
* Remove redundant Provides: go-doc=%{version} per rpmlint warning
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar accepted review
dimstar_suse set openSUSE:Factory:Staging:G as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:G"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:G"
licensedigger accepted review
ok
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:G got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:G got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:G got accepted.
