Overview
Request 837911 accepted
Superseding because the hashable patch needs a fix
- New upstream patch pyqt5-customaudio-qt511.patch
* versionize QCustomAudioRoleControl for older Leaps
* https://www.riverbankcomputing.com/pipermail/pyqt/2020-September/043241.html
- Updated patch pyqt5-signals-hashable.patch
* Fix typedef for old python versions
* Patch is submitted to the PyQt5 mailing list
- Fix qtbot failures pyqt5-signals-hashable.patch, see
* https://www.riverbankcomputing.com/pipermail/pyqt/2020-September/043160.html
* gh#pytest-dev/pytest-qt#316
- Created by bnavigator
- In state accepted
- Supersedes 835880
+1 to me, waiting for another opinion.
Since the patch * is from the creator of PyQt * only adds a missing interface I cannot see any downsides here...
+1
Request History
bnavigator created request
Superseding because the hashable patch needs a fix
- New upstream patch pyqt5-customaudio-qt511.patch
* versionize QCustomAudioRoleControl for older Leaps
* https://www.riverbankcomputing.com/pipermail/pyqt/2020-September/043241.html
- Updated patch pyqt5-signals-hashable.patch
* Fix typedef for old python versions
* Patch is submitted to the PyQt5 mailing list
- Fix qtbot failures pyqt5-signals-hashable.patch, see
* https://www.riverbankcomputing.com/pipermail/pyqt/2020-September/043160.html
* gh#pytest-dev/pytest-qt#316
bnavigator added frispete as a reviewer
frispete accepted review
LGTM, good work, Ben!
frispete approved review
LGTM, good work, Ben!
luca_b accepted request
More than enough approvals. ;) Thanks for the patience.
FYI, I got a private message from the upstream maintainer approving my fix to the pyqt5-signals-hashable.patch in reply to https://www.riverbankcomputing.com/pipermail/pyqt/2020-September/043243.html