Overview

Request 839395 superseded

Properly track compat symlinks


Stefan Dirsch's avatar

Hmm. Unfortunately this doesn't consider /etc/X11/xinit/xinitrc.common at all. I doubt we'll ever get rid of this compatibily link. We cannot patch files in user's $HOME.

Also I don't see how I could get rid of xdm-config and Xservers, which is patched depending on values in /etc/sysconfig/displaymanager. This config file is a different story. I would like to keep this separate!

I still need to find out who/when Keyboard.map is being used. It could be during build process to generate Linux console keymaps. In that case packaging would even be good!

In short. For now I'm fine with packaging Xsession Xsetup Xstartup Xreset Keyboard.map. The remaining symlinks I still want to create on the fly.


Fabian Vogt's avatar

Hmm. Unfortunately this doesn't consider /etc/X11/xinit/xinitrc.common at all. I doubt we'll ever get rid of this compatibily link. We cannot patch files in user's $HOME.

This sr has two packages, xinitrc.common is part of xinit.

Also I don't see how I could get rid of xdm-config and Xservers, which is patched depending on values in /etc/sysconfig/displaymanager. This config file is a different story. I would like to keep this separate!

I see, but previously those were normal files and tracked by xdm, so I wonder how that worked.

I still need to find out who/when Keyboard.map is being used. It could be during build process to generate Linux console keymaps. In that case packaging would even be good!

No idea, there are no hits in /usr or /etc. systemd uses its own /usr/share/systemd/kbd-model-map and YaST has its own stuff on top. So it might even be ok to just drop it?

In short. For now I'm fine with packaging Xsession Xsetup Xstartup Xreset Keyboard.map. The remaining symlinks I still want to create on the fly.

Ok, I'll supersede.


Fabian Vogt's avatar

Also I don't see how I could get rid of xdm-config and Xservers, which is patched depending on values in /etc/sysconfig/displaymanager. This config file is a different story. I would like to keep this separate!

I just checked, SUSEConfig is dead and nothing appears to write into those files anymore.

And I also found where Keyboard.map was used, but not anymore:

https://github.com/yast/yast-x11/commit/baa8e08b00849e74178f051b162a224b9bc985d4#diff-e9c878ace42e215f62349413d22bf3df


Fabian Vogt's avatar

I just checked, SUSEConfig is dead and nothing appears to write into those files anymore.

/etc/X11/xdm/SuSEconfig.xdm is called by /usr/lib/X11/display-manager, bah.


Stefan Dirsch's avatar

Yeah. it's still in use. ;-)


Stefan Dirsch's avatar

Keyboard.map: Ah. I read it wrongly. It converted in the different direction and has been replaced meanwhile. I can remove it completely.


Stefan Dirsch's avatar

Ah. You moved /etc/X11/xinit/xinitrc.common to a xinit package. As said, we'll never get rid of it in a working system. I still prefer having it created on-the-fly if the admin removed everything below /etc.


Fabian Vogt's avatar

Recreating it on-the-fly is fine, but it has to be tracked by rpm as well.


Stefan Dirsch's avatar

As ghost then? But then a file below /etc will still be in the package, which is no longer allowed, right?


Fabian Vogt's avatar

I don't think it'll ever be forbidden to ship files below /etc, especially not for cases like this where it's about users we don't have control over (~/.xinitrc). I would just track it as normal file, so that rpm -qV (rightfully) complains if it's missing.


Stefan Dirsch's avatar

Ok. Mabye you're right.

Request History
Fabian Vogt's avatar

Vogtinator created request

Properly track compat symlinks


Fabian Vogt's avatar

Vogtinator superseded request

superseded by 839544

openSUSE Build Service is sponsored by