Overview
Request 844902 accepted
- Fix setup.py to correctly identify the project packages git_deps
and git_deps/listener. These were not being packaged and as a
result the git-deps command was simply failing
- Fix issue with unbuffered text I/O under python3, as identified in
https://github.com/aspiers/git-deps/pull/93/commits/6beebe034b5c6fd19d73edd774dbf424ea183fee
I couldn't make sense of the "test" which accompanies the source code. i think it's out of date, so I didn't add any tests
FYI - the spec file changes are due to OBS, it's not a change which I made myself.
Does the package has some test suite? It would be lovely if we have one.
It does seem so. I'll look into using it. One thing worth mentioning is that one additional fix is needed. I can resubmit with those two things addressed.
Request History
bfrogers created request
- Fix setup.py to correctly identify the project packages git_deps
and git_deps/listener. These were not being packaged and as a
result the git-deps command was simply failing
- Fix issue with unbuffered text I/O under python3, as identified in
https://github.com/aspiers/git-deps/pull/93/commits/6beebe034b5c6fd19d73edd774dbf424ea183fee
I couldn't make sense of the "test" which accompanies the source code. i think it's out of date, so I didn't add any tests
mcepl accepted request
Group is not needed anymore - why would you add one? I mean its not an issue but its kinda pointless.
The osc tool apparently did this, as I didn't edit the spec file except to add the new patch. I didn't feel like arguing with the automated changes which seems fine to me.
Just to say that https://en.opensuse.org/openSUSE:Packaging_Patches_guidelines is really interesting piece of reading, highly suggested to use it, I can then find out even a year after I added that patch, why did I do it, and whether it has been reported upstream.