This request supersedes:
request 845286
(Show diff)
Overview
Loading...
Request History
awissu created request
- Weak dependencies: Use Supplements tag as recommended
tumbler-folder-thumbnailer/tumbler-webp-thumbnailer dependencies
for main package
mauriziogalli accepted request
Ok. Let's accept this first and I'll make a separate SR to remove the hard dependency
Could you please explain this change why it’s needed?
When installing tumbler package from the repository is pulling in other unnecessary dependencies.
For example: zypper in --recommends tumbler (tumbler ->tumbler-folder-thumbnailer -> thunar)
Or pantheon-files file manager installing
zypper in --recommeds pantheon-files (pantheon-files -> tumbler ->tumbler-folder-thumbnailer -> thunar)
Why install thunar file manager?
Thunar is currently a hard dependency of tumbler-folder-thumbnailer so I think we should change that too.
However if I understand "supplements" correctly, they are like a reversed "recommends", and you still would end up with thunar installed, would you not?
I think this could be handled from thunar / pantheon-files side instead, to Recommend tumbler and remove the dependencies to either in this package.
Using the Supplements tag:
zypper in --recommends tumbler - thumbler will only be installed
zypper in --recommends thunar - two packages will be installed (thunar -> tumbler-folder-thumbnailer)
or:
zypper in --recommends thunar (thunar)
zypper in --recommends tumbler (tumbler -> tumbler-folder-thumbnailer)
or:
zypper in --recommends tumbler thunar (tumble -> thunar -> tumbler-folder-thumbnailer)
i.e.:
if [ "tumble" && " thunar" ]; then tumbler-folder-thumbnailer fi
See: https://build.opensuse.org/package/view_file/X11:Pantheon/elementary-files/elementary-files.spec
As temporary solution ... :
Add Provides tag to pantheon-files.spec: (Provides: tumbler-folder-thumbnailer)
https://build.opensuse.org/package/view_file/X11:Pantheon:Branch/elementary-files/elementary-files.spec
I suggest we:
1) Requires: thunar >= 1.8.2 (Requires -> Suggests) so that we break the hard dependency but still get the correct version of thunar when needed
~~2) Remove the Recommends of tumbler-folder-thumbnailer and tumbler-webp-thumbnailer. Also let's not add Supplements in this package because it is kinda redundant. Both Thunar and Pantheon already Recommend it.~~
2) The Supplements way you suggested is fine
See:
https://build.opensuse.org/package/view_file/X11:Pantheon/elementary-files/elementary-files.spec
https://build.opensuse.org/package/view_file/X11:xfce/thunar/thunar.spec
3) Save recommended dependencies and remove the hard dependency.