Overview

Request 853781 superseded

New package Radicale. See https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/WE6JSMDNGTNZAZZTPNEQKNIFLGXFDUC3/

Loading...

Dominique Leuenberger's avatar

First (quick) review - I might add more comments:

  • 58+%{?systemd_requires} should not be used; consider the container use-case, which is certainly not far off for this type of server; There is no system In there (different entry points). The %service_ macros can all handle the absence of systems

in the service file: * 11+ExecStart=/usr/bin/env python3 -m radical: preferably, a package does never use /usr/bin/env - this will call out to the shell and find any ranomd python3 'binary' (in the context of systems service probably less critical than actual system binaries) - better to give full path to the interpreter, ensuring the package uses system provided, packaged binaries.

Request History
Ákos Szőts's avatar

szotsaki created request

New package Radicale. See https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/thread/WE6JSMDNGTNZAZZTPNEQKNIFLGXFDUC3/


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar_suse added openSUSE:Factory:Staging:adi:63 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:63"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:63"


Ákos Szőts's avatar

szotsaki superseded request

superseded by 854535

openSUSE Build Service is sponsored by