Overview
Request 906834 revoked
Change libbpf.pc to list /usr/lib* instead of /usr/local/lib* in the linker flags (-L).
There is nothing installed in /usr/local by this package, and more importantly it breaks CMake builds of reverse dependencies as it gets added to the RPATH and it confuses SUSE's version of CMake:
[ 20s] file RPATH_CHANGE could not write new RPATH:
[ 20s]
[ 20s]
[ 20s]
[ 20s] to the file:
[ 20s]
[ 20s] /home/abuild/rpmbuild/BUILDROOT/dwarves-1.21+git175.1ef87b2-21.1.x86_64/usr/bin/codiff
[ 20s]
[ 20s] The current RUNPATH is:
[ 20s]
[ 20s] /home/abuild/rpmbuild/BUILD/dwarves-1.21+git175.1ef87b2/build:
[ 20s]
[ 20s] which does not contain:
[ 20s]
[ 20s] /usr/local/lib64:/home/abuild/rpmbuild/BUILD/dwarves-1.21+git175.1ef87b2/build:
[ 20s]
[ 20s] as was expected.
[ 19s] /usr/bin/cc -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DNDEBUG -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g -DNDEBUG -flto=auto -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now -rdynamic CMakeFiles/codiff.dir/codiff.c.o -o codiff -L/usr/local/lib64 -Wl,-rpath,/usr/local/lib64:/home/abuild/rpmbuild/BUILD/dwarves-1.21+git175.1ef87b2/build: libdwarves.so.1.0.0 -ldw -lelf -lz -lbpf
See: https://www.spinics.net/lists/dwarves/msg01350.html
- Created by bluca
- In state revoked
- Open review for licensedigger
- Open review for factory-staging
Request History
bluca created request
Change libbpf.pc to list /usr/lib* instead of /usr/local/lib* in the linker flags (-L).
There is nothing installed in /usr/local by this package, and more importantly it breaks CMake builds of reverse dependencies as it gets added to the RPATH and it confuses SUSE's version of CMake:
[ 20s] file RPATH_CHANGE could not write new RPATH:
[ 20s]
[ 20s]
[ 20s]
[ 20s] to the file:
[ 20s]
[ 20s] /home/abuild/rpmbuild/BUILDROOT/dwarves-1.21+git175.1ef87b2-21.1.x86_64/usr/bin/codiff
[ 20s]
[ 20s] The current RUNPATH is:
[ 20s]
[ 20s] /home/abuild/rpmbuild/BUILD/dwarves-1.21+git175.1ef87b2/build:
[ 20s]
[ 20s] which does not contain:
[ 20s]
[ 20s] /usr/local/lib64:/home/abuild/rpmbuild/BUILD/dwarves-1.21+git175.1ef87b2/build:
[ 20s]
[ 20s] as was expected.
[ 19s] /usr/bin/cc -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DNDEBUG -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g -DNDEBUG -flto=auto -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now -rdynamic CMakeFiles/codiff.dir/codiff.c.o -o codiff -L/usr/local/lib64 -Wl,-rpath,/usr/local/lib64:/home/abuild/rpmbuild/BUILD/dwarves-1.21+git175.1ef87b2/build: libdwarves.so.1.0.0 -ldw -lelf -lz -lbpf
See: https://www.spinics.net/lists/dwarves/msg01350.html
factory-auto declined review
Expected submission from devel package devel:libraries:c_c++/libbpf
factory-auto declined request
Expected submission from devel package devel:libraries:c_c++/libbpf
bluca revoked request
This is of course a quick hack, there might be a better way to fix it. It would probably be better to use libbpf sources from Github, as that's more distro-friendly, and it's what Fedora/Debian/Ubuntu use.
Resubmitted to devel https://build.opensuse.org/request/show/906835