Overview
Request 922632 revoked
- Disable build for s390x
- Remove noarch as it uses arch dependent files
- Created by pallavideshmukh
- In state revoked
Loading...
Request History
pallavideshmukh created request
- Disable build for s390x
- Remove noarch as it uses arch dependent files
M0ses declined request
Added ExcludeArch in
https://github.com/M0ses/kanku/blob/master/dist/kanku.spec#L33
Testing in
https://build.opensuse.org/package/show/devel:kanku:staging/kanku
Once again - THX for your contribution
adrianSuSE revoked request
The source project 'home:pallavideshmukh:branches:openSUSE:Factory:zSystems' has been removed
@M0ses: review reminder
Thanks for your contribution.
looks like the changelog doesn't match the patch - I don't see where you removed "noarch".
And I don`t understand this line:
%if "%{_arch}" == "x86_64" || "%{_arch}" == "i686" || "%{_arch}" == "s390x"arch == s390 should never happen as you excluded s390. IMO, the exclude of s390 is a good idea, but I think with
ExcludeArch: s390xwe should be done, correct?Another topic: The spec file of kanku is maintained here: https://github.com/M0ses/kanku/blob/master/dist/kanku.spec. Would you mind to file an github PR or should I simple add it to the spec file?