Request 931267: Submit gstreamer-plugins-rs

This request supersedes: request 929018 (Show diff)

Overview

Request 931267 accepted

New package, gives gstreamer support for dav1d and rav1e as the major important things.

Created by iznogood over 2 years ago
In state accepted
Supersedes 929018

Submit gstreamer-plugins-rs

Comments for request 931267 0
Comments for request 929018 4

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

 5+- Filter out pkgconfig(csound) Requires, add manual csound-devel
 6+  BuildRequires to devel package. csound-devel does not provide a
 7+  .pc file so the autogenerated Requires on pkconfig(csound) is
 8+  wrong.

Does that even work then? We install a devel file that has a .pc file with a requires: sound.

pkg-config --libs tries to follow these deps - so I'd very strongly expect this to fail with the installed pc file

Bjørn Lie (iznogood) - over 2 years ago

author source maintainer

csound upstream do not provide a .pc file (there is a open issue for it). gstreamer-rs for some reason tries to find csound via pkgconf even if there is no such thing available.

cc = meson.get_compiler('c')
csound_option = get_option('csound')
# try first to find csound using pkg-config
csound_dep = dependency('', required: false)
if not csound_dep.found() and not csound_option.disabled()
  # if csound isn't distributed with pkg-config then user needs to define CSOUND_LIB_DIR with its location
  python3 = import('python').find_installation()
  res = run_command(python3, '-c', 'import os; print(os.environ["CSOUND_LIB_DIR"])')
  if res.returncode() == 0
    csound_libdir = res.stdout().strip()
    csound_dep = cc.find_library('csound64', dirs: csound_libdir, required: false)
    if csound_dep.found()
      extra_env += {'CSOUND_LIB_DIR': csound_libdir}
    endif
  endif
endif

if csound_dep.found()
  plugins += {'gst-plugin-csound' : 'libgstcsound'}
elif csound_option.enabled()
  error('csound option is enabled, but csound64 library could not be found and CSOUND_LIB_DIR was not set')
else
  message('csound not found, disabling its plugin')
endif

We just export the csound_lib_dir in spec - this might be the reason it pkgconf thinks csound have the needed bits.

As I said in the sr to devel project, if anyone have a better idea - please sub it.

Bjørn Lie (iznogood) - over 2 years ago

author source maintainer

We could also just disable csound for now if maintainer is ok with that, until this mess is handled correctly upstream, be it csound or this package?