Overview

Request 932834 accepted

Initial packaging required by libwacom (bsc#1192852).


Dominique Leuenberger's avatar
38+BuildRequires:  libevdev%{libevdev_sover} >= %{libevdev_reqver}
39+Requires:       libevdev%{libevdev_sover} >= %{libevdev_reqver}

BuildRequiring a library is 99.995% the wrong thing to do - BuildRequire the respective devel package

Requring a specific .so.<n> from any other package than the one being built is a recipe for disaster; the library versions can change, which ,makes packaging more annoying than needed.

Do something like finding the right package name based on the .so symlink (installed by the devel package) - then you get a dynamically correct dependency on the correct package


Callum Farmer's avatar

I know. However this has no proper build system and hardcodes it.

@staticmethod def _cdll(): return ctypes.CDLL("libevdev.so.2", use_errno=True)


Dominique Leuenberger's avatar

Ouch - it's even worse than expected... bu tin this case, ok, not much we can do better with THIS code


Matej Cepl's avatar
author source maintainer

OK, this is so bad (I cannot believe wot created something so horrible), cannot we make libwacom use python-evdev instead?


Callum Farmer's avatar

It also uses the equally terrible python-pyudev and I wouldn't know anyway ask the libwacom maintainer.

Request History
Matej Cepl's avatar

mcepl created request

Initial packaging required by libwacom (bsc#1192852).


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:D as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:D"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:D"


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:D got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:D got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:D got accepted.

openSUSE Build Service is sponsored by