Overview

Request 938264 accepted

- Update to version 0.2.2:
+ The frontpage is now visible. You can see it by going to / in
the url bar.
+ The app now supports Flatpak & NixOS installation
+ Performance improvements in the comments view
+ The codebase is now tested! I'm pretty sure this is one of the
only GTK+ apps which has proper UI tests - so this should stop
more regressions in the future!
- Changes from version 0.2.1:
+ Replaced the markdown engine, should now support more features
+ The alignment in subreddit listings should now be more uniform
+ Many size related bugs have been fixed
+ The url bar is now less lenient on formatting. Previously,
going to /linux would take you to /r/linux. Due to the
frontpage changes, this no longer happens
+ [PACKAGING] Moved icons from pixmaps to the hicolor directory
+ [PACKAGING] Change SCSS compiler from ruby sass to sassc
- Drop desktop.patch: Fixed upstream.
- Replace ruby(sass) for sassc
- Fix python env to be py3 via sed call
- Modernize spec, drop no longer needed post(un) calls.


Luciano Santos's avatar
reviewer target maintainer

Do we still run %suse_update_desktop_file, or only when changing categories?

About runtime dependencies, the built package in your home repo have the following symbol requirements:

  • python(abi) = 3.8
  • python3-Markdown
  • python3-arrow
  • python3-gobject-Gdk
  • typelib(GLib)
  • typelib(GObject)
  • typelib(Gdk)
  • typelib-1_0-Gtk-4_0
  • typelib-1_0-Gtk-2_0
  • typelib(GdkPixbuf)
  • typelib(Gio)
  • typelib(Pango)
  • typelib(Gtk) = 3.0
  • typelib(Soup) = 2.4
  • typelib(WebKit2) = 4.0

Shouldn't we put some explicit requirements on the spec file? Enlighten me, my memory is a bit foggy.


Dominique Leuenberger's avatar

Do we still run %suse_update_desktop_file, or only when changing categories?

Yes, we do, when needed

As for the deps: what OBS shows is the extracted requirement symbols from the built RPM - as they are in the rpm, there is no need to list them in the spec file (many are auto-calculated)


Luciano Santos's avatar
reviewer target maintainer

That's nice.

Request History
Bjørn Lie's avatar

iznogood created request

- Update to version 0.2.2:
+ The frontpage is now visible. You can see it by going to / in
the url bar.
+ The app now supports Flatpak & NixOS installation
+ Performance improvements in the comments view
+ The codebase is now tested! I'm pretty sure this is one of the
only GTK+ apps which has proper UI tests - so this should stop
more regressions in the future!
- Changes from version 0.2.1:
+ Replaced the markdown engine, should now support more features
+ The alignment in subreddit listings should now be more uniform
+ Many size related bugs have been fixed
+ The url bar is now less lenient on formatting. Previously,
going to /linux would take you to /r/linux. Due to the
frontpage changes, this no longer happens
+ [PACKAGING] Moved icons from pixmaps to the hicolor directory
+ [PACKAGING] Change SCSS compiler from ruby sass to sassc
- Drop desktop.patch: Fixed upstream.
- Replace ruby(sass) for sassc
- Fix python env to be py3 via sed call
- Modernize spec, drop no longer needed post(un) calls.


GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar approved review


Bjørn Lie's avatar

iznogood accepted request

xinfwd

openSUSE Build Service is sponsored by