Request 945555 (superseded)

This request is superseded by request 945558 (Show diff)

Overview

Request 945555 superseded

initial package

Created by sebix over 2 years ago
In state superseded
Supersedes 944819
Superseded by 945558
Open review for licensedigger
Open review for openSUSE:Factory:Staging:adi:30
Open review for opensuse-review-team

Submit git-repo

Comments for request 945555 4

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

 2+-------------------------------------------------------------------
 3+Tue Jan 11 10:09:27 UTC 2022 - Sebastian Wagner <sebix+novell.com@sebix.at>
 4+
 5+- Fix shebang to use python3.9.

why? It's much better to use the system default python interpreter; Doesn't py 3.8 work with this?

Sebastian Wagner (sebix) - over 2 years ago

author source maintainer

I tried it, but the code uses Path.readlink() which is only available on Python >= 3.9 :/

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

Maybe add something alike either next to the dep in the spec, or at least to the changelog entry. So not only document the 'fact' that you use py3.9, but also add a reason for it

Not sure if we should go py 3.9 or rather py 3.10 (which is the one becoming default next)

Sebastian Wagner (sebix) - over 2 years ago

author source maintainer

Looking at it again it might be easier to just patch it. I'll try that approach first.