Overview
Request 946499 superseded
- move shared options for all the gmic-qt versions into a define
to reduce duplication
- Rework patches:
- drop old patches with git generated copies:
- 5e34754707b78358ef818d542d1e81d008bb2d12.patch
- dont-set-gmic_build.patch
- gmic-krita5.patch
- make-build-without-gmic-cpp.patch
- new patches:
- gmic-make-build-without-gmic-cpp.patch
- gmic-qt-make-it-work-without-gmic-cpp.patch
- krita5.patch
- Update krita patch so we can apply it as normal patch without
breaking other gmic-qt instances
- Remove unneeded BuildRequires fftw3-devel and cmake(KF5CoreAddons)
- Use simpler syntax for the pkg version comparison
- enable building with Krita 5
new BR: krita-devel
new patches:
- 5e34754707b78358ef818d542d1e81d008bb2d12.patch
- gmic-krita5.patch
- Add dont-set-gmic_build.patch:
Make gmic-qt flavors build without gmic.cpp. This should help
with getting the new krita plugin built
- enable opencv support xshm support
- Add BuildRequires xorg-x11-devel
- add missing files for to make the devel package work:
make-build-without-gmic-cpp.patch
- also track series for easier patching
- Add Conflicts for krita >= 5 as it needs the intree version of
gmic-qt now
- Update to 3.0.1
https://discuss.pixls.us/t/on-the-road-to-3-1/28221
BuildRequires: fftw3-devel
is not needed, pkgconfig(fftw3) is already present
%if %{pkg_version_cmp krita 5} >= 0
→ %if %{pkg_vcmp krita > 5}
I had weirdness without the fftw3-devel but i can try it again
There's no need to %define hostapps gimp krita
twice, %define hostapps gimp
could be in the %bcond_without block instead
series is useless
Please annotate the patch in the spec file
Patches shall have a description and an origin
series is not useless as it helps to make quilt work without installing all the packages for all macros.
%make_jobs
→ %cmake_build
or cmake --build plugin-build
for this case
Please enable the leap build. If I'm not mistaken, you will have an error in post build checks due to
++ install(FILES gmic_krita_qt.desktop DESTINATION ${CMAKE_INSTALL_PREFIX}/bin OPTIONAL)
Request History
darix created request
- move shared options for all the gmic-qt versions into a define
to reduce duplication
- Rework patches:
- drop old patches with git generated copies:
- 5e34754707b78358ef818d542d1e81d008bb2d12.patch
- dont-set-gmic_build.patch
- gmic-krita5.patch
- make-build-without-gmic-cpp.patch
- new patches:
- gmic-make-build-without-gmic-cpp.patch
- gmic-qt-make-it-work-without-gmic-cpp.patch
- krita5.patch
- Update krita patch so we can apply it as normal patch without
breaking other gmic-qt instances
- Remove unneeded BuildRequires fftw3-devel and cmake(KF5CoreAddons)
- Use simpler syntax for the pkg version comparison
- enable building with Krita 5
new BR: krita-devel
new patches:
- 5e34754707b78358ef818d542d1e81d008bb2d12.patch
- gmic-krita5.patch
- Add dont-set-gmic_build.patch:
Make gmic-qt flavors build without gmic.cpp. This should help
with getting the new krita plugin built
- enable opencv support xshm support
- Add BuildRequires xorg-x11-devel
- add missing files for to make the devel package work:
make-build-without-gmic-cpp.patch
- also track series for easier patching
- Add Conflicts for krita >= 5 as it needs the intree version of
gmic-qt now
- Update to 3.0.1
https://discuss.pixls.us/t/on-the-road-to-3-1/28221
superseded by 946512