Overview
Request 951631 superseded
Made a few more adjustments, mainly cleaning up hardcoded dir paths to their macro equivalent.
- Created by sbradnick
- In state superseded
- Supersedes 950800
- Superseded by 951651
-
Open review for
opensuse-review-team
- Open review for openSUSE:Factory:Staging:adi:22
found conflict of hyper-v-enhanced-session-1.0.0-1.1.noarch with xrdp-0.9.15-2.3.x86_64 /etc/xrdp [mode mismatch: d755 root:root, n d755 root:root]
Where does that show up? I'm not seeing it in zypper or build logs. I'd like to see it so I can determine if I've fixed it. Thanks!
It's the result of the install checker bot
Ahh, thank you sir - I saw "installcheck"(w/ a link) days ago but foolishly never clicked on it. Seems so obvious now. I see it's from 8 days ago and the last set of changes are ~2 days ago - is it something that's reset (or goes away) with a run of:
osc sr -s 950800 Virtualization/hyper-v-enhanced-session openSUSE:Factory
?
installcheck is one of the adi checks; whenever the package changes (so different sources submitted) the adi will recalculate the state and thus present a new installcheck report
the problem is probably best fixed in xrdp - where /etc/xrdp is packaged in a conflicting manner:
in xrdp.spec:
…
%files
…
%dir %{_sysconfdir}/xrdp
%dir %{_sysconfdir}/xrdp/pulse
%config(noreplace) %{_sysconfdir}/pam.d/xrdp-sesman
%config(noreplace) %{_sysconfdir}/xrdp/sesman.ini
%config(noreplace) %{_sysconfdir}/xrdp/xrdp.ini
…
%config(noreplace) %{_sysconfdir}/xrdp/
%ghost %config(noreplace) %{_sysconfdir}/xrdp/rsakeys.ini
so in fact it packages the entire /etc/xrdp once clean (using the %dir directive) and then again as config(noreplace), recursively
This also results in quite a lengthy warning list in the build log of xrdp:
[ 124s] warning: File listed twice: /etc/xrdp [ 124s] warning: File listed twice: /etc/xrdp/km-00000406.ini [ 124s] warning: File listed twice: /etc/xrdp/km-00000407.ini [ 124s] warning: File listed twice: /etc/xrdp/km-00000409.ini [ 124s] warning: File listed twice: /etc/xrdp/km-0000040a.ini [ 124s] warning: File listed twice: /etc/xrdp/km-0000040b.ini [ 124s] warning: File listed twice: /etc/xrdp/km-0000040c.ini [ 124s] warning: File listed twice: /etc/xrdp/km-00000410.ini [ 124s] warning: File listed twice: /etc/xrdp/km-00000411.ini [ 124s] warning: File listed twice: /etc/xrdp/km-00000412.ini [ 124s] warning: File listed twice: /etc/xrdp/km-00000414.ini [ 124s] warning: File listed twice: /etc/xrdp/km-00000415.ini [ 124s] warning: File listed twice: /etc/xrdp/km-00000416.ini
I'll try to work out a clean fix to that; in this case, I think your package only helped expose an issue in another package
I've removed the "%dir %{_sysconfdir}/xrdp" line from my .spec file as well ; the build doesn't complain about it (not being there) and I was thinking that line was causing the issue.
Should I hold off on "osc sr -s 950800 ..." for 'hyper-v-enhanced-session' while 'xrdp' is being worked on?
No need to wait - you can submit the fix right away; my fix is also in the pipeline and they can run in parallel
Request History
sbradnick created request
Made a few more adjustments, mainly cleaning up hardcoded dir paths to their macro equivalent.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:22"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:22"
Adding '%dir %{_sysconfdir}/xrdp' back, staging build fails without it.
Odd ... it builds locally ; it builds via home:sbradnick:branches:Virtualization ; it builds via Virtualization ~ but fails with:
[ 29s] hyper-v-enhanced-session-1.0.0-1.2.noarch.rpm: directories not owned by a package: [ 29s] - /etc/xrdp
via openSUSE:Factory:Staging:adi:22. I can add "%dir %{_sysconfdir}/xrdp" back ~ hopefully that doesn't compound anything w/ the "xrdp" package.