@mnhauke: review reminder

@huzihizhao

This is the second time I see this when fixing a package. Did you add this nonsense anywhere else? It disables the test suite for everything. There is no python_flavor "python362" and and alphanumeric comparison with real flavors like "python310" does not work here:

Besides "%{python_flavor}" is not expanded to multiple flavors in the %check context or similar blocks.

Specfile

%check
%if "%{python_flavor}" >= "python362"
echo '"%{python_flavor}" >= "python362"' is true
%else
echo '"%{python_flavor}" >= "python362"' is false
%endif
exit 1

Tumbleweed:

[    2s] + echo '"python310" >= "python362"' is false
[    2s] "python310" >= "python362" is false
[    2s] + exit 1

15.4:

[   17s] + echo '"python3" >= "python362"' is false
[   17s] "python3" >= "python362" is false
[   17s] + exit 1

I have submitted 2 requests, and another is here: https://build.opensuse.org/request/show/972492?notification_id=32123710

What my intention is to ignore the test for python3.62 since the packages don't support it. Will it work as my intention if I change python362 to python36?

Benjamin Greiner (bnavigator) - almost 2 years ago

The packaging change has already been reverted and was eqaully wrong. Those SRs should never have been accepted.

Your intended change will not work either.

Read https://en.opensuse.org/openSUSE:Packaging_Python and https://github.com/openSUSE/python-rpm-macros

If the tests don't work with Python 3.6 there is a reason for it. You can't use the package with Python 3.6 unless you fix it.