Overview
Request 998514 superseded
Implemented suggestions plus various improvements.
- Created by crameleon
- In state superseded
- Package maintainer: crameleon
- Supersedes 970190
- Superseded by 998515
@darix, @gerritbeine, @jmcdough, @lrupp, @m4z, @pbleser, @wrosenauer: review reminder
Hello @darix, thank you very much for your most excellent review!
It took me a while, but I now implemented most of your suggestions - except for point 1, which I kindly ask for assistance with - if I remove the %{goprep}
phase then no /tmp/importpath.txt
is created, and %{gocheck}
fails. Do you have an idea about that? Or should I keep the %{goprep}
as I have it?
As for your concern about the initdb
and mkcerts
commands - yes, I made sure the program handles those correctly. By calling them inside my spec-file it is ensured the user gets a server installation which works out of the box without any additional configuration. But once a db and certificates already exist, the program will gracefully skip the generation.
I managed to build it without %{goprep}
now and added some further additions. Will submit a new SR shortly.
Request History
crameleon created request
Implemented suggestions plus various improvements.
Implemented suggestions plus various improvements.