Overview
A couple comments:
Please run spec-cleaner, it will reformat the spec file to match the openSUSE conventions
The
%undefineline and%{?dist}are not neededBy default, the
%cmakemacro passes-DCMAKE_BUILD_TYPE=RelWithDebInfoto create debug packages. It almost never needs to be replaced by something else. Why do you need-DCMAKE_BUILD_TYPE=Release?Nitpick: Don't use macros for the URL tag: We have the
osc updatepacmetafromspecwhich updates the description visible on the build service. It would replace the package name; add the URL and theNo description seton https://build.opensuse.org/package/show/home:chrtall:desktop-applications/birdtray for example. But it doesn't expand variables.The _service file doesn't look useful. You can just run
osc service disabledrun download_files.
If you wish to keep it, the openSUSE Tumbleweed policy is to only allow disabled services.
Another note about the %check section:
By default, tests are not built. See https://github.com/gyunaev/birdtray/blob/master/CMakeLists.txt#L190.
You need to add -DBUILD_WITH_TESTS=ON and also add the needed build requirement.
I made the changes you requested, but I was not able to build with -DBUILD_WITH_TESTS=ON, even after adding the GTest Dependency, because GMock::GMock, could not be resolved. I removed the tests from %check for now. Do I have to submit a request again after commiting?
I had a quick look at your branch. BuildRequires: libpcre1 can't be right.
This is not a build dependency
I am still looking for a solution. The build fails, when I remove libpcre1. I did not have to add this dependency, before I submitted the request.
What's the build error? There's no explicit use of pcre1 in the birdtray code.
The build error is the following: RPM build warnings: [ 19s] Empty %files file /home/abuild/rpmbuild/BUILD/birdtray-1.9.0/debugsourcefiles.list [ 19s] ... checking for files with abuild user/group [ 19s] ... running 00-check-install-rpms [ 19s] ... installing all built rpms [ 19s] Verifying packages... [ 19s] Preparing packages... [ 19s] birdtray-debugsource-1.9.0-0.x86_64 [ 19s] birdtray-1.9.0-0.x86_64 [ 19s] ... running 50-check-binary-kernel-log [ 19s] ... running 50-check-core-files [ 19s] ... running 50-check-debuginfo [ 19s] ... testing for empty debuginfo packages [ 19s] grep: error while loading shared libraries: libpcre.so.1: cannot open shared object file: No such file or directory [ 19s] ! [ 19s] ! //.build.packages/RPMS/x86_64/birdtray-debugsource-1.9.0-0.x86_64.rpm: empty debuginfo/debugsource package, deleting [ 19s] ! [ 19s] ... running 50-check-filelist [ 19s] ... checking filelist [ 19s] ... running 50-check-gconf-scriptlets [ 19s] ... testing GConf scriptlet presence [ 19s] ... running 50-check-installtest [ 19s] ... testing for pre/postinstall scripts that are not idempotent [ 19s] ... running 50-check-invalid-provides [ 19s] grep: error while loading shared libraries: libpcre.so.1: cannot open shared object file: No such file or directory [ 19s] ... running 50-check-invalid-requires [ 19s] grep: error while loading shared libraries: libpcre.so.1: cannot open shared object file: No such file or directory [ 19s] xargs: rpm: terminated by signal 13 [ 19s] ... running 50-check-kernel-build-id [ 19s] ... running 50-check-lanana [ 19s] ... running 50-check-libtool-deps [ 19s] ... testing devel dependencies required by libtool .la files [ 19s] grep: error while loading shared libraries: libpcre.so.1: cannot open shared object file: No such file or directory 19s [ 19s] grep: error while loading shared libraries: libpcre.so.1: cannot open shared object file: No such file or directory [ 19s] ... running 50-check-packaged-twice [ 19s] grep: error while loading shared libraries: libpcre.so.1: cannot open shared object file: No such file or directory [ 19s] grep: error while loading shared libraries: libpcre.so.1: cannot open shared object file: No such file or directory [ 19s] [ 19s] [ 19s] localhost.localdomain failed "build birdtray.spec" at Thu Nov 3 10:36:02 UTC 2022. [ 19s]
Maybe you know what the problem is, because I didn´t figure it out.
That's not a problem in the spec but in the post-build checks.
If the errors are still present, they have to be fixed elsewhere.
I managed to fix the problem. It appears that it was only my local build machine that was giving me the error. I reinstalled osc and now everything works. If you could be so kind to tell me how I can submit the latest changes from my home repository to this request, you could check if everything is right now.
osc submitrequest home:chrtall:desktop-applications birdtray Office will ask you if the request shall supersede the old one, answer yes
Request History
chrtall created request
Made the suggested changes to the spec file.
cgiboudeaux accepted request
LGTM
