+%attr (-,%{name},%{name}) /var/lib/%{name}/scripts/async.sh
+%attr (-,%{name},%{name}) /var/lib/%{name}/scripts/echo.sh
+%attr (-,%{name},%{name}) /var/lib/%{name}/scripts/long.sh

are those scripts to be modified by webhookd? if not ... /usr/share/webhookd or so might be better

why is the %pre so far from the other scriptlets?

your %pre scriptlets lacks

%pre -f %{name}.pre

so that the user gets setup

+%config %{_sysconfdir}/default/%{name}

is this is supposed to be edited by the user it should be %config(noreplace)

-ldflags=-s

remove that and add to your preamble:

%go_nostrip

+%autosetup -p1
+%setup -T -D -a 3

why not

%autosetup -p1 -a 3

any reason why other archs are not supported? +ExclusiveArch: x86_64

you can probably leave out those parts and should get binaries for other architectures?

+GOOS=linux GOARCH=amd64 

a better work directory might be the home directory of the user +[Service] +WorkingDirectory=/usr/bin/

Why this?

+# Disable timeout logic and wait until process is stopped
+TimeoutStopSec=infinity
+SendSIGKILL=no

Thank you for your feedback. This is my first package. :)

are those scripts to be modified by webhookd? if not ... /usr/share/webhookd or so might be better

You are right. I moved it to /usr/share/webhookd

your %pre scriptlets lacks is this is supposed to be edited by the user it should be %config(noreplace) why not %autosetup -p1 -a 3

I added it! thanks

Why this?
+# Disable timeout logic and wait until process is stopped +TimeoutStopSec=infinity +SendSIGKILL=no

I copied this from another systemd file and see no sense of it. I removed it.

a better work directory might be the home directory of the user

I removed it because I see no sense in a working directory. AFAIK the Service does not save anything to the disk. It only executes scripts when a REST API is called.

-ldflags=-s remove that and add to your preamble: %go_nostrip

I am not sure how to use it correctly, in the Go Packaging Guide is a warning that you should not use that and in the next sentence it says that is has been already fixed. My problem is that I am completely new and thought the manual way of building it is the easiest for me, but I am open for any feedback.

any reason why other archs are not supported? +ExclusiveArch: x86_64

First, because I do not know how to write a package build for more than one architecture but mostly because I cannot test it on other architectures.

I commited the feedback

a better work directory might be the home directory of the user

I removed it because I see no sense in a working directory. AFAIK the Service does not save anything to the disk. It only executes scripts when a REST API is called.

I've found a good WorkingDirectory and added it.

Adam Majer (adamm) - 12 months ago

target maintainer

You will need to resubmit a new request once you finish making changes in the home project. You should then supersede this request.

osc request supersede 1056712 [NEW_RQ_ID]

---

Michael Brunner (sm0x) - 11 months ago

author source maintainer

Thank you. I did it definitely wrong. How can I remove the supersede ID? Where do I get the new REQ_ID?

Update: I've tried to open a new request (1088726) and tried to change the REQ_ID but it doesn't work:

michael@MikeBookAir-II:~/Development/packaging/home:sm0x/webhookd> osc submitrequest -m "I want to maintain webhookd in Factory and would like to use server:http as the devel/feeder project." home:sm0x/webhookd server:http/webhookd
Warning: failed to fetch meta data for 'server:http' package 'webhookd' (new package?) 
created request id 1088726
michael@MikeBookAir-II:~/Development/packaging/home:sm0x/webhookd> osc request supersede 1056712 1088726

 *** The state of the request (#1056712) is already 'superseded'. Change state anyway?  [y/n] *** y
HTTP Error 403: Forbidden
post_request_no_permission
set state to superseded from a final state is not allowed.

@MargueriteSu, @adamm, @ammler, @darix, @jgotteswinter, @lrupp, @schubi2, @weigon: review reminder